Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IVF cleanup + trackJetPt as TaggingVariable: Backport from 7_1_X to 6_2_X_SLHC #3612

Conversation

ferencek
Copy link
Contributor

Backport of #2941 but without any changes to the RECO sequence

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_6_2_X_SLHC.

IVF cleanup + trackJetPt as TaggingVariable: Backport from 7_1_X to 6_2_X_SLHC

It involves the following packages:

DataFormats/BTauReco
PhysicsTools/PatAlgos
RecoBTag/SecondaryVertex
RecoVertex/AdaptiveVertexFinder

@nclopezo, @monttj, @cmsbuild, @anton-a, @thspeer, @slava77, @vadler, @Degano can you please review it and eventually sign? Thanks.
@TaiSakuma, @GiacomoSguazzoni, @rovere, @nhanvtran, @cerati, @pvmulder this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2014

-1
I ran the usual tests and I found errors in the following unit tests:

---> test runtestTqafTopHitFit had ERRORS
---> test runtestTqafTopEventProducers had ERRORS
---> test runtestTqafTopJetCombination had ERRORS
---> test runtestTqafExamples had ERRORS
---> test runtestTqafTopKinFitter had ERRORS
---> test runtestTqafTopTools had ERRORS
---> test runtestPhysicsToolsPatAlgos had ERRORS
---> test runtestTqafTopEventSelection had ERRORS
---> test runtestUtilAlgos had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3612/24/summary.html

@ferencek
Copy link
Contributor Author

ferencek commented May 2, 2014

Errors seem to be either ConfigFileReadErrors (unrelated to the code changes proposed in this PR) or problems with opening input files.

@mark-grimes
Copy link

merge

Failing tests mentioned above don't work for SLHC. Had some spurious test failures, but retried and they seem to have been anomalous. Tests 10000, 10200, 10400, 11200, 11400, 12000, 12800, 13000, 13600 and 14600 pass all steps. Tests 12400, 12600, 13800 and 14000 fail in step 2 with known errors. Tests 12200, 14200 and 14400 fail in step 3 with known errors.

cmsbuild added a commit that referenced this pull request May 8, 2014
…CMSSW_6_2_X_SLHC_2014-04-29-1400

IVF cleanup + trackJetPt as TaggingVariable: Backport from 7_1_X to 6_2_X_SLHC
@cmsbuild cmsbuild merged commit 1453e83 into cms-sw:CMSSW_6_2_X_SLHC May 8, 2014
@ferencek ferencek deleted the IVFcleanup-trackJetPt_from-CMSSW_6_2_X_SLHC_2014-04-29-1400 branch May 8, 2014 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants