Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate HLTPrescaleRecorder and AlignPCLThresholdsWriter to new PoolDBOutputService methods #36142

Merged
merged 1 commit into from Nov 17, 2021

Conversation

francescobrivio
Copy link
Contributor

PR description:

Part of cms-AlCaDB/AlCaTools#28.
Migrated to use the new PoolDBOutput methods in:

  • In HLTPrescaleRecorder.cc migrated from createNewIOV+appendSinceTime to writeOneIOV
  • In AlignPCLThresholdsWriter.cc I switched from pointer to instance for AlignPCLThresholds myThresholds

PR validation:

Code compiles and scramv1 b runtests runs fine.

Backport

N/A

FYI @mmusich

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36142/26675

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

  • CondFormats/PCLConfig (db, alca)
  • HLTrigger/HLTcore (hlt)

@malbouis, @yuanchao, @cmsbuild, @missirol, @Martin-Grunewald, @ggovi, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@silviodonato, @tocheng, @Martin-Grunewald, @missirol, @mmusich, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36142/26677

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

Pull request #36142 was updated. @malbouis, @yuanchao, @cmsbuild, @missirol, @Martin-Grunewald, @ggovi, @tvami, @francescobrivio can you please check and sign again.

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6419b7/20570/summary.html
COMMIT: dfbacef
CMSSW: CMSSW_12_2_X_2021-11-16-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36142/20570/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3320802
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3320780
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36142/26687

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

Pull request #36142 was updated. @malbouis, @yuanchao, @cmsbuild, @missirol, @Martin-Grunewald, @ggovi, @tvami, @francescobrivio can you please check and sign again.

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6419b7/20577/summary.html
COMMIT: e1c8b0a
CMSSW: CMSSW_12_2_X_2021-11-16-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36142/20577/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3320802
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3320780
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor

+hlt

@francescobrivio, thanks for taking care of the update in HLTrigger/.

@ggovi
Copy link
Contributor

ggovi commented Nov 17, 2021

+db

@tvami
Copy link
Contributor

tvami commented Nov 17, 2021

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2792782 into cms-sw:master Nov 17, 2021
@francescobrivio francescobrivio deleted the alca-PoolDBOutputMigration branch November 21, 2021 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants