Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport]: Customisation snippet for full-range M0 default in HCAL reco #36162

Merged
merged 2 commits into from Nov 20, 2021

Conversation

abdoulline
Copy link

@abdoulline abdoulline commented Nov 17, 2021

PR description:

Backport of #36161

At PPD Coordination on Wed. 17 Nov. it was agreed to use this customization for pilot beam re-reco instead of default MAHI, as HCAL time alignment was quite questionable during data taking.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 17, 2021

A new Pull Request was created by @abdoulline (Salavat Abdullin) for CMSSW_12_1_X.

It involves the following packages:

  • RecoLocalCalo/HcalRecProducers (reconstruction)

@jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@apsallid, @mariadalfonso, @bsunanda this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Nov 18, 2021

@cmsbuild please test

@slava77
Copy link
Contributor

slava77 commented Nov 18, 2021

@abdoulline
please clarify how urgent is this (and/or when a release with this is going to be needed).
Thank you.

@abdoulline
Copy link
Author

abdoulline commented Nov 18, 2021

@slava77
I suppose it's rather urgent, as needed for re-reco of the pilot beam (test) data.
A bit of context: HCAL time alignment wasn't done very well, so default MAHI scale is off substantially and rather arbitrarily across the detector.
As @mseidel42 has mentioned in the sibling of this PR (12_2 one) #36161 (comment)
it was agreed yesterday at PPD coordination.

@slava77
Copy link
Contributor

slava77 commented Nov 18, 2021

urgent

@cmsbuild
Copy link
Contributor

Pull request #36162 was updated. @jpata, @cmsbuild, @slava77 can you please check and sign again.

@abdoulline
Copy link
Author

@slava77 done the same (as for 12_2 PR) suggested naming and location change

@slava77
Copy link
Contributor

slava77 commented Nov 18, 2021

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b7f002/20618/summary.html
COMMIT: 5ea513a
CMSSW: CMSSW_12_1_X_2021-11-18-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36162/20618/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 2901440
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2901411
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 41 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@slava77
Copy link
Contributor

slava77 commented Nov 18, 2021

backport of #36161

@slava77
Copy link
Contributor

slava77 commented Nov 18, 2021

+reconstruction

for #36162 5ea513a

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Nov 20, 2021

+1

@cmsbuild cmsbuild merged commit 923d8cd into cms-sw:CMSSW_12_1_X Nov 20, 2021
@abdoulline abdoulline deleted the M0_full-range_default_12_1 branch December 6, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants