Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated DQMOffline/Muon package for Run3 #36166

Merged
merged 14 commits into from Nov 30, 2021
Merged

Conversation

calderona
Copy link
Contributor

Some minor changes have been implemented in view of the next Run3 data taking and certification:

  • Removed the DTSegmentMonitor folder (currently not used by the muon POG)
  • Changes in PU ranges to extend them for next Run3 and modified for Phase2
  • Minor changes for some plot names

It has been tested on the following samples:

34850 ZMM, No PU, 14TeV, 2026 upgrade
1330.0 ZMM, noPU, 13TeV standard
136.867 RunSingleMu2018B, standard

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36166/26721

  • This PR adds an extra 40KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @calderona for master.

It involves the following packages:

  • DQMOffline/Muon (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@sscruz, @barvic, @abbiendi, @Fedespring, @bellan, @HuguesBrun, @jhgoh, @ptcox, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a2cc5d/20612/summary.html
COMMIT: 41a544b
CMSSW: CMSSW_12_2_X_2021-11-18-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36166/20612/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3325752
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 1560
  • DQMHistoTests: Total successes: 3324162
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -258.695 KiB( 41 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): -5.289 KiB Muons/DTSegmentsMonitor
  • DQMHistoSizes: changed ( 1000.0,... ): -4.682 KiB Muons/Isolation
  • DQMHistoSizes: changed ( 1000.0,... ): 2.812 KiB Muons/EfficiencyAnalyzer
  • DQMHistoSizes: changed ( 10024.0,... ): -4.682 KiB Muons_miniAOD/Isolation
  • DQMHistoSizes: changed ( 10024.0,... ): 2.812 KiB Muons_miniAOD/EfficiencyAnalyzer
  • DQMHistoSizes: changed ( 23234.0,... ): 11.540 KiB Muons/MuonEnergyDepositAnalyzer
  • DQMHistoSizes: changed ( 23234.0,... ): -7.025 KiB Muons/Isolation
  • DQMHistoSizes: changed ( 23234.0,... ): -7.025 KiB Muons_miniAOD/Isolation
  • DQMHistoSizes: changed ( 23234.0,... ): -3.447 KiB Muons_miniAOD/EfficiencyAnalyzer
  • DQMHistoSizes: changed ( 23234.0,... ): 1.406 KiB Muons/EfficiencyAnalyzer
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1
Changes expected and validated by the developer

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a2cc5d/20853/summary.html
COMMIT: 044a4fd
CMSSW: CMSSW_12_2_X_2021-11-29-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36166/20853/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

SyntaxError: invalid syntax

gmake[1]: *** [config/SCRAM/GMake/Makefile.rules:1834: CompilePython] Error 1
gmake[1]: Target 'PostBuild' not remade because of errors.
gmake[1]: Leaving directory '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_2_X_2021-11-29-1100'
gmake: *** [config/SCRAM/GMake/Makefile.rules:1722: src] Error 2
gmake: Target 'all' not remade because of errors.
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2
+ eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --ignoreWarning=Wdeprecated-declarations --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_2_X_2021-11-29-1100/tmp/slc7_amd64_gcc900/cache/log/src '||' 'true)'
++ scram build outputlog
>> Entering Package DQMOffline/Muon


@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36166/27004

  • This PR adds an extra 84KB to repository

@cmsbuild
Copy link
Contributor

Pull request #36166 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a2cc5d/20856/summary.html
COMMIT: 43b6a1a
CMSSW: CMSSW_12_2_X_2021-11-29-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36166/20856/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 41
  • DQMHistoTests: Total histograms compared: 3040978
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1343
  • DQMHistoTests: Total successes: 3039600
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -222.591 KiB( 40 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): -5.289 KiB Muons/DTSegmentsMonitor
  • DQMHistoSizes: changed ( 1000.0,... ): -4.682 KiB Muons/Isolation
  • DQMHistoSizes: changed ( 1000.0,... ): 2.812 KiB Muons/EfficiencyAnalyzer
  • DQMHistoSizes: changed ( 10024.0,... ): -4.682 KiB Muons_miniAOD/Isolation
  • DQMHistoSizes: changed ( 10024.0,... ): 2.812 KiB Muons_miniAOD/EfficiencyAnalyzer
  • DQMHistoSizes: changed ( 23234.0,... ): 11.540 KiB Muons/MuonEnergyDepositAnalyzer
  • DQMHistoSizes: changed ( 23234.0,... ): -7.025 KiB Muons/Isolation
  • DQMHistoSizes: changed ( 23234.0,... ): -7.025 KiB Muons_miniAOD/Isolation
  • DQMHistoSizes: changed ( 23234.0,... ): -3.447 KiB Muons_miniAOD/EfficiencyAnalyzer
  • DQMHistoSizes: changed ( 23234.0,... ): 1.406 KiB Muons/EfficiencyAnalyzer
  • DQMHistoSizes: changed ( 312.0 ): ...
  • Checked 175 log files, 37 edm output root files, 41 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit bcc6320 into cms-sw:master Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants