New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-alca211B Make an application to study isotracks using generated particles #36183
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36183/26759
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36183/26760
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages:
@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@yuanchao can you please take this one? I'll review the other one. |
@tvami The other came out while trying to work with tuning a new reconstruction algorithm and it was ready for a while. I only forgot to commit them. The second one came out while reviewing isotrack calibration and we need some time to put it in place for use. This PR is made so that we can share the work among a group of people. |
@cmsbuild Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-79578e/20710/summary.html Comparison SummarySummary:
|
@yuanchao have you had the chance to review this? |
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Make an application in Calibration/HcalCalibAlgos to study isotracks using generated particles
PR validation:
Tested using a MC Reco dataset
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special