Migrate misc scripts to new `PoolDBOutputService` methods #36196

francescobrivio · 2021-11-21T18:50:55Z

PR description:

Part of cms-AlCaDB/AlCaTools#28.
Migrated the following packages:

Calibration/LumiAlCaRecoProducers/plugins/CorrPCCProducer.cc
CondFormats/RecoMuonObjects/test/ProduceAgingObject.cc
CondTools/BTau/plugins/BTagCalibrationDbCreator.cc
MuonAnalysis/MomentumScaleCalibration/plugins/DBWriter.cc
PhysicsTools/MVAComputer/test/testWriteMVAComputerCondDB.cc
RecoHI/HiCentralityAlgos/plugins/CentralityTableProducer.cc
RecoMuon/GlobalTrackingTools/test/DYTTuner.cc
RecoParticleFlow/PFClusterTools/test/ProducePFCalibrationObject.cc
SimGeneral/MixingModule/plugins/Mixing2DB.cc

PR validation:

Code compiles and scramv1 b runtests runs fine.

Backport:

N/A

cmsbuild · 2021-11-21T18:59:11Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36196/26786

This PR adds an extra 36KB to repository

cmsbuild · 2021-11-21T18:59:35Z

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

Calibration/LumiAlCaRecoProducers (alca)
CondFormats/RecoMuonObjects (db, alca)
CondTools/BTau (db)
MuonAnalysis/MomentumScaleCalibration (analysis)
PhysicsTools/MVAComputer (analysis)
RecoHI/HiCentralityAlgos (reconstruction)
RecoMuon/GlobalTrackingTools (reconstruction)
RecoParticleFlow/PFClusterTools (reconstruction)
SimGeneral/MixingModule (simulation)

@malbouis, @civanch, @yuanchao, @mdhildreth, @cmsbuild, @ggovi, @slava77, @jpata, @tvami, @santocch, @francescobrivio can you please review it and eventually sign? Thanks.
@emilbols, @abbiendi, @CeliaFernandez, @argiro, @jazzitup, @thomreis, @demuller, @seemasharmafnal, @mmarionncern, @calderona, @makortel, @dgulhan, @jhgoh, @amagitte, @sscruz, @slomeo, @simonepigazzini, @trocino, @lgray, @rociovilar, @cbernet, @tocheng, @bellan, @cericeci, @hatakeyamak, @mmusich, @fabiocos, @AlexDeMoor, @HuguesBrun, @rchatter, @mandrenguyen, @battibass, @Fedespring, @JyothsnaKomaragiri, @yenjie, @kurtejung, @andrzejnovak, @yetkinyilmaz this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

francescobrivio · 2021-11-21T19:00:11Z

@cmsbuild please test

cmsbuild · 2021-11-21T22:10:42Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-588c25/20650/summary.html
COMMIT: a381a27
CMSSW: CMSSW_12_2_X_2021-11-21-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36196/20650/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS StaticAnalyzer warnings: There are 1 inherits from legacy modules warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-588c25/20650/llvm-analysis/legacy-mod-sa.txt for details.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 42
DQMHistoTests: Total histograms compared: 3247021
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3246993
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
Checked 177 log files, 37 edm output root files, 42 DQM output files
TriggerResults: no differences found

MuonAnalysis/MomentumScaleCalibration/plugins/DBWriter.cc

jpata · 2021-11-23T09:22:52Z

+reconstruction

technical, no reco changes
note the following warning about CentralityTableProducer (cc @mandrenguyen and HI colleagues)

/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_2_X_2021-11-21-0000/src/RecoHI/HiCentralityAlgos/plugins/CentralityTableProducer.cc:39:1: warning: CentralityTableProducer inherits from edm::EDProducer,edm::EDFilter,edm::EDAnalyzer, or edm::OutputModule [deprecated.edmChecker]

yuanchao · 2021-11-23T15:13:06Z

+1

new pooldboutputservice method migration
technical, tests passed
(related package need to migrate to new EDM classes)

civanch · 2021-11-24T05:23:48Z

+1

cmsbuild · 2021-11-24T22:22:48Z

Pull request #36196 was updated. @malbouis, @civanch, @yuanchao, @mdhildreth, @cmsbuild, @ggovi, @slava77, @jpata, @tvami, @santocch, @francescobrivio can you please check and sign again.

francescobrivio · 2021-11-24T22:29:15Z

@cmsbuild please test

cmsbuild · 2021-11-25T01:43:08Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-588c25/20748/summary.html
COMMIT: 943101c
CMSSW: CMSSW_12_2_X_2021-11-24-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36196/20748/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS StaticAnalyzer warnings: There are 1 inherits from legacy modules warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-588c25/20748/llvm-analysis/legacy-mod-sa.txt for details.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 42
DQMHistoTests: Total histograms compared: 3247025
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3247003
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
Checked 177 log files, 37 edm output root files, 42 DQM output files
TriggerResults: no differences found

tvami · 2021-11-25T02:15:23Z

+1

code changes in line w PR description
Jenkins tests pass

perrotta · 2021-11-25T06:35:48Z

+1

The only change committed since when this PR was fully signed is a trivial technical fix in RecoHI/HiCentralityAlgos/plugins/CentralityTableProducer.cc, which I suppose @cms-sw/reconstruction-l2 can agree with
All other signatures can be considered as already given, and I assume that @cms-sw/analysis-l2 will have a look in the coming days and also approve the technical updates in the analysis related code (otherwise, just propose the possible amendments for them)
Other fixes and updates should be applied to some of the code touched here, but I agree with @francescobrivio that it should be dealt with by the developers/maintainers in a separate PR

perrotta · 2021-11-25T06:37:54Z

merge

santocch · 2021-11-28T17:57:48Z

+1

jfernan2 · 2023-09-18T08:17:07Z

+1

cmsbuild · 2023-09-18T10:49:20Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-588c25/34794/summary.html
COMMIT: 943101c
CMSSW: CMSSW_13_3_X_2023-09-17-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36196/34794/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 3 lines to the logs
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3348648
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3348623
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 214 log files, 167 edm output root files, 50 DQM output files
TriggerResults: no differences found

Migrate misc scripts to new PoolDBOutputService methods

a381a27

cmsbuild added this to the CMSSW_12_2_X milestone Nov 21, 2021

cmsbuild added alca-pending analysis-pending code-checks-pending db-pending orp-pending pending-signatures reconstruction-pending simulation-pending tests-pending labels Nov 21, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 21, 2021

cmsbuild added tests-started and removed tests-pending labels Nov 21, 2021

cmsbuild added tests-approved and removed tests-started labels Nov 21, 2021

ggovi reviewed Nov 22, 2021

View reviewed changes

MuonAnalysis/MomentumScaleCalibration/plugins/DBWriter.cc Show resolved Hide resolved

cmsbuild mentioned this pull request Nov 23, 2021

Migrate JetMET and PF codes to new PoolDBOutputService methods #36214

Merged

cmsbuild added alca-approved reconstruction-approved and removed reconstruction-pending alca-pending labels Nov 23, 2021

cmsbuild added the code-checks-approved label Nov 24, 2021

cmsbuild added tests-started and removed tests-pending labels Nov 24, 2021

cmsbuild added tests-approved and removed tests-started labels Nov 25, 2021

cmsbuild added alca-approved db-approved and removed alca-pending db-pending labels Nov 25, 2021

cmsbuild added orp-approved and removed orp-pending labels Nov 25, 2021

cmsbuild merged commit 3f1d306 into cms-sw:master Nov 25, 2021

cmsbuild added analysis-approved and removed analysis-pending labels Nov 28, 2021

francescobrivio deleted the alca-PoolDBOutputMigration_misc branch December 1, 2021 17:27

cmsbuild added reconstruction-approved tests-started and removed reconstruction-pending tests-approved labels Sep 18, 2023

cmsbuild added tests-approved and removed tests-started labels Sep 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate misc scripts to new `PoolDBOutputService` methods #36196

Migrate misc scripts to new `PoolDBOutputService` methods #36196

francescobrivio commented Nov 21, 2021

cmsbuild commented Nov 21, 2021

cmsbuild commented Nov 21, 2021

francescobrivio commented Nov 21, 2021

cmsbuild commented Nov 21, 2021

jpata commented Nov 23, 2021

yuanchao commented Nov 23, 2021

civanch commented Nov 24, 2021

cmsbuild commented Nov 24, 2021

francescobrivio commented Nov 24, 2021

cmsbuild commented Nov 25, 2021

tvami commented Nov 25, 2021

perrotta commented Nov 25, 2021

perrotta commented Nov 25, 2021

santocch commented Nov 28, 2021

jfernan2 commented Sep 18, 2023

cmsbuild commented Sep 18, 2023

Migrate misc scripts to new PoolDBOutputService methods #36196

Migrate misc scripts to new PoolDBOutputService methods #36196

Conversation

francescobrivio commented Nov 21, 2021

PR description:

PR validation:

Backport:

cmsbuild commented Nov 21, 2021

cmsbuild commented Nov 21, 2021

francescobrivio commented Nov 21, 2021

cmsbuild commented Nov 21, 2021

Comparison Summary

jpata commented Nov 23, 2021

yuanchao commented Nov 23, 2021

civanch commented Nov 24, 2021

cmsbuild commented Nov 24, 2021

francescobrivio commented Nov 24, 2021

cmsbuild commented Nov 25, 2021

Comparison Summary

tvami commented Nov 25, 2021

perrotta commented Nov 25, 2021

perrotta commented Nov 25, 2021

santocch commented Nov 28, 2021

jfernan2 commented Sep 18, 2023

cmsbuild commented Sep 18, 2023

Comparison Summary

Migrate misc scripts to new `PoolDBOutputService` methods #36196

Migrate misc scripts to new `PoolDBOutputService` methods #36196