Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecation warnings from several Calib* subsystem #36200

Merged
merged 7 commits into from Nov 22, 2021

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Nov 22, 2021

PR description:

Title says is all. Went systematically through all CMSDEPRECATED_X warnings for some Calib* subsystem.

  • removed EventSetup::get() calls
  • migrated away from deprecated EDModules API
  • put class headers of plugins in the same file as implementation
  • modernized code

PR validation:

cmssw compiles

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36200/26798

  • This PR adds an extra 80KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • CalibTracker/SiPixelConnectivity (alca)
  • CalibTracker/SiPixelGainCalibration (alca)
  • CalibTracker/SiPixelIsAliveCalibration (alca)
  • CalibTracker/SiStripChannelGain (alca)
  • CalibTracker/SiStripDCS (alca)
  • CalibTracker/SiStripHitEfficiency (alca)
  • Calibration/TkAlCaRecoProducers (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@echabert, @rchatter, @threus, @pieterdavid, @robervalwalsh, @gbenelli, @tocheng, @argiro, @OzAmram, @ferencek, @dkotlins, @thomreis, @simonepigazzini, @mmusich, @alesaggio, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Nov 22, 2021

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d44b7d/20667/summary.html
COMMIT: 60582f4
CMSSW: CMSSW_12_2_X_2021-11-22-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36200/20667/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3247021
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3246999
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Nov 22, 2021

+alca

  • test pass
  • PR in line with description

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 06cae6f into cms-sw:master Nov 22, 2021
@mmusich mmusich deleted the deprecationWarningsCalibration branch November 22, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants