Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2D TPG data-vs-emulation summary plots for L1T CSC DQM #36226

Merged
merged 1 commit into from Nov 24, 2021
Merged

Add 2D TPG data-vs-emulation summary plots for L1T CSC DQM #36226

merged 1 commit into from Nov 24, 2021

Conversation

dildick
Copy link
Contributor

@dildick dildick commented Nov 23, 2021

PR description:

As requested by CSC DPG and by DQM conveners (#33085 (comment)), this PR adds a few 2D summary plots for the CSC TPG data-vs-emulation in the DQM. There are 6 plots, 2 for each object ALCT/CLCT/LCT. For each object I have a 2D plot that shows the efficiency to correctly emulate the data objects, and a plot that shows the percentage of emulated objects that do not have a data counterpart. Emulated and data objects are compared with an operator== function, or a custom equality function.

PR validation:

Tested on 15k events of Run 322022. A few plots are shown below. Plots with 26k events can be seen here: #36046 (comment)

Plots

if this PR is a backport please specify the original PR and why you need to backport that PR:

N.A.

@ptcox @tahuang1991 @giovanni-mocellin

@dildick
Copy link
Contributor Author

dildick commented Nov 23, 2021

Screen Shot 2021-11-23 at 2 12 08 PM

Screen Shot 2021-11-23 at 2 12 27 PM

Screen Shot 2021-11-23 at 2 12 46 PM

Screen Shot 2021-11-23 at 2 17 58 PM

Screen Shot 2021-11-23 at 2 18 09 PM

Screen Shot 2021-11-23 at 2 18 19 PM

@dildick
Copy link
Contributor Author

dildick commented Nov 23, 2021

If desired the 1D plots can be turned of with make1DPlots (set to False). But I would not do that until after physics data. These 2D plots and the 1D plots will be very useful in the start of next year to understand the CSC TP data-vs-emulation.

@giovanni-mocellin

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36226/26842

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

  • DQM/L1TMonitor (dqm)
  • DQM/L1TMonitorClient (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f0911/20726/summary.html
COMMIT: 995b665
CMSSW: CMSSW_12_2_X_2021-11-23-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36226/20726/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3247025
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3247003
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 868.032 KiB( 41 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 54.252 KiB L1TEMU/L1TdeCSCTPG
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

@dildick alct_csctp_emul_summary_num and lct_csctp_emul_summary_num appear empty in all the WFs, despite your test plots looked fine. Do you think is just stats (workflows have 10 events only)?

@dildick
Copy link
Contributor Author

dildick commented Nov 24, 2021

Yes, the "emul" summary plots indicate emulated ALCTs/CLCTs/LCTs without matching idea. Ideally this plot is completely empty, even at high statistics. Because then it means that there are no excess trigger primitives in the simulation.

@jfernan2
Copy link
Contributor

I understand thanks, I had interpreted them the other way around...

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants