Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restored the ShieldingME4 and fixed all the MUON overlaps in muonYoke.xml #36234

Merged
merged 2 commits into from Nov 26, 2021

Conversation

slomeo
Copy link
Contributor

@slomeo slomeo commented Nov 24, 2021

PR description:

Restored the ShieldingME4 and fixed all the MUON overlaps in muonYoke.xml
A new version of muonYoke.xml is created (i.e 2026/v2/muonYoke.xml)

@bsunanda @ianna @cvuosalo @civanch @etcherniaev : FYI

PR validation:

  1. validation by "cmsShow.exe -c overlaps.fwc --sim-geom-file cmsSimGeom-2026.root"

  2. validation by "nohup cmsRun SimG4Core/PrintGeomInfo/test/python/g4OverlapCheck2026_cfg.py >& overlaps.out &"
    Muon's volumes are not present in the overlaps.out file.

if this PR is a backport please specify the original PR and why you need to backport that PR:

nothing special

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36234/26864

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slomeo (Sergio Lo Meo) for master.

It involves the following packages:

  • Geometry/CMSCommonData (geometry, upgrade)
  • Geometry/MuonCommonData (geometry)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@ptcox, @bsunanda, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

please test

@srimanob
Copy link
Contributor

Thanks very much @slomeo

By the way, why do you touch only
Geometry/CMSCommonData/data/dd4hep/cmsExtendedGeometry2026D86.xml
but not the definition of M10 (of D86)?
https://github.com/cms-sw/cmssw/blob/master/Configuration/Geometry/python/dict2026Geometry.py#L1280

@slomeo
Copy link
Contributor Author

slomeo commented Nov 24, 2021

Hi @srimanob

but not the definition of M10 (of D86)? https://github.com/cms-sw/cmssw/blob/master/Configuration/Geometry/python/dict2026Geometry.py#L1280

because if I understood well, I think that @bsunanda wants to do this job.

@bsunanda , please let me know

@bsunanda
Copy link
Contributor

Please do not change Configuration/Geometry/python/dict,, and also please restore the old cmsExtendedGeometry2026D26XML_cfi.py. I am preparing the next version of scenario.

@srimanob
Copy link
Contributor

OK, then I think we should do it in a cleaner way. For example,

  • This PR adds only XML, and we touch all D86 XMLs in a separate PR.
  • Or this PR includes all changes needed for D86

@srimanob
Copy link
Contributor

Our comments cross @bsunanda
It seems we agree that this PR adds XML.
@slomeo Would you mind updating also the PR title and description to reflect the change. Thanks again.

@slomeo
Copy link
Contributor Author

slomeo commented Nov 24, 2021

ok @srimanob, probably it is better that this PR is related only to muonYoke.xml

what do I have to do now?

@slomeo
Copy link
Contributor Author

slomeo commented Nov 24, 2021

do I have to make a new "commit" without msExtendedGeometry2026D86.xml? I'm sorry but I don't understand because I never edited cmsExtendedGeometry2026D86XML_cfi.py as @bsunanda wrote.

@srimanob
Copy link
Contributor

You can change back this file,
Geometry/CMSCommonData/data/dd4hep/cmsExtendedGeometry2026D86.xml
and commit & push again. The PR test will stop when you push the new one.
Then change the title and description of the PR.

@slomeo
Copy link
Contributor Author

slomeo commented Nov 24, 2021

ok

@bsunanda
Copy link
Contributor

@cmsbuild Please test

@slomeo slomeo changed the title Restored the ShieldingME4 and fixed all the MUON overlaps in 2026D86 Restored the ShieldingME4 and fixed all the MUON overlaps in muonYoke.xml Nov 24, 2021
@slomeo
Copy link
Contributor Author

slomeo commented Nov 24, 2021

@srimanob @bsunanda cmsExtendedGeometry2026D86.xml restored and PR title changed

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36234/26870

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

Pull request #36234 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6e9b40/20745/summary.html
COMMIT: 0403ae7
CMSSW: CMSSW_12_2_X_2021-11-23-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36234/20745/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3247025
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3247003
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Nov 25, 2021

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Nov 26, 2021

+1

@cmsbuild cmsbuild merged commit 65ba78d into cms-sw:master Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants