Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use thread safe modules in DPGAnalysis/SiStripTools #36321

Merged
merged 1 commit into from Dec 7, 2021

Conversation

Dr15Jones
Copy link
Contributor

PR description:

Migrated all modules to thread-safe versions.

PR validation:

Code compiles and no more CMS_DEPRECATED warnings appear.

Migrated all modules to thread-safe versions.
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36321/27058

  • This PR adds an extra 84KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2021

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

  • DPGAnalysis/SiStripTools (analysis)

@cmsbuild, @santocch can you please review it and eventually sign? Thanks.
@echabert, @mtosi, @pieterdavid, @robervalwalsh, @JanFSchulte, @VinInn, @jandrea, @mmusich, @threus, @venturia this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

@makortel FYI

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a2a278/20909/summary.html
COMMIT: 71fbca3
CMSSW: CMSSW_12_2_X_2021-12-01-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36321/20909/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 41
  • DQMHistoTests: Total histograms compared: 3041955
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3041921
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 40 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 175 log files, 37 edm output root files, 41 DQM output files
  • TriggerResults: no differences found

@Dr15Jones
Copy link
Contributor Author

ping @cms-sw/analysis-l2

@smuzaffar smuzaffar modified the milestones: CMSSW_12_2_X, CMSSW_12_3_X Dec 6, 2021
@qliphy
Copy link
Contributor

qliphy commented Dec 7, 2021

+1

@qliphy
Copy link
Contributor

qliphy commented Dec 7, 2021

merge

@cmsbuild cmsbuild merged commit 1122cb3 into cms-sw:master Dec 7, 2021
@Dr15Jones Dr15Jones deleted the modernizeDPGAnalysisSiStripTools branch December 13, 2021 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants