Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_1_X] Add PilotBeam data in relval matrix and update Run3 data offline GT #36329

Merged
merged 2 commits into from Dec 3, 2021

Conversation

francescobrivio
Copy link
Contributor

PR description:

This PR is partially a backport of #36133 since it adds the PilotBeam data to the relval matrix workflows, and partially a backport of #36326 since it contains updates to the offline Run3 data GT in preparation for the re-reco.

Changes are:

Diff in GT:
Run 3 data (offline)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_dataRun3_v8/121X_dataRun3_v12

PR validation:

Validated with:
runTheMatrix.py -l 136.897,136.899,138.1,138.2,138.3,138.4,138.5,139.001,139.002,139.003,139.004 -j8 --ibeos

Backport:

Partial backport of #36133 and #36326

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2021

A new Pull Request was created by @francescobrivio for CMSSW_12_1_X.

It involves the following packages:

  • Configuration/AlCa (alca)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • Configuration/StandardSequences (operations)
  • DQMOffline/L1Trigger (dqm, l1)

@bbilin, @wajidalikhan, @pmandrik, @rekovic, @cecilecaillol, @perrotta, @yuanchao, @ahmad3213, @cmsbuild, @davidlange6, @emanueleusai, @AdrianoDee, @jfernan2, @kskovpen, @qliphy, @fabiocos, @pbo0, @francescobrivio, @malbouis, @jordan-martins, @srimanob, @rvenditti, @tvami can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @felicepantaleo, @slomeo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @ebrondol, @tocheng, @lecriste, @mmusich, @mtosi, @dgulhan, @kpedro88, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Dec 1, 2021

backport of #36133

@tvami
Copy link
Contributor

tvami commented Dec 1, 2021

backport of #36326

@francescobrivio
Copy link
Contributor Author

urgent

@cmsbuild cmsbuild added the urgent label Dec 1, 2021
@francescobrivio
Copy link
Contributor Author

test parameters:

  • workflows = 136.897,136.899,138.1,138.2,138.3,138.4,138.5,139.001,139.002,139.003,139.004

@tvami
Copy link
Contributor

tvami commented Dec 1, 2021

code-checks

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36329/27070

  • This PR adds an extra 56KB to repository

@tvami
Copy link
Contributor

tvami commented Dec 1, 2021

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f55c69/20920/summary.html
COMMIT: 5318bc2
CMSSW: CMSSW_12_1_X_2021-12-01-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36329/20920/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f55c69/20920/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f55c69/20920/git-merge-result

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-f55c69/136.897_RunCosmics2021CRUZET+RunCosmics2021CRUZET+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCR3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-f55c69/136.899_RunCosmics2021CRAFT+RunCosmics2021CRAFT+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCR3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-f55c69/138.1_PromptCosmics+RunCosmics2021+RECOCOSDPROMPTRUN3+ALCACOSDPROMPTRUN3+HARVESTDCPROMPTRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-f55c69/138.2_ExpressCosmics+RunCosmics2021+RECOCOSDEXPRUN3+ALCACOSDEXPRUN3+HARVESTDCEXPRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-f55c69/138.3_Splashes+RunMinimumBias2021Splash+COPYPASTER3+RECODR3Splash+HARVESTDR3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-f55c69/138.4_PromptCollisions+RunMinimumBias2021+ALCARECOPROMPTR3+HARVESTDPROMPTR3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-f55c69/138.5_ExpressCollisions+RunMinimumBias2021+TIER0EXPRUN3+ALCARECOEXPR3+HARVESTDEXPR3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-f55c69/139.001_RunMinimumBias2021+RunMinimumBias2021+HLTDR3_2021+RECODR3_MinBiasOffline+HARVESTD2021MB
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-f55c69/139.002_RunZeroBias2021+RunZeroBias2021+HLTDR3_2021+RECODR3_ZBOffline+HARVESTD2021ZB
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-f55c69/139.003_RunHLTPhy2021+RunHLTPhy2021+HLTDR3_2021+RECODR3_HLTPhysics_Offline+HARVESTD2021HLTPhy
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-f55c69/139.004_RunNoBPTX2021+RunNoBPTX2021+HLTDR3_2021+RECODR3_AlCaTkCosmics_Offline+HARVESTDR3

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 2901440
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2901412
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

srimanob commented Dec 2, 2021

+Upgrade

@jfernan2
Copy link
Contributor

jfernan2 commented Dec 2, 2021

+1

@kskovpen
Copy link
Contributor

kskovpen commented Dec 2, 2021

+1

@francescobrivio
Copy link
Contributor Author

Thanks to all for the prompt signature, I let my colleagues @malbouis or @tvami add the alca signature.
@cms-sw/l1-l2 a kind ping, your signature is required because the same updates to L1T configs as in #36133 are applied here in this backport.

@tvami
Copy link
Contributor

tvami commented Dec 2, 2021

+alca

@tvami
Copy link
Contributor

tvami commented Dec 2, 2021

@perrotta @qliphy since this is a backport, maybe we can again skip the L1T signiture? There is a L1T signiture on the master PR so I'm sure Vladimir agrees.

@perrotta
Copy link
Contributor

perrotta commented Dec 3, 2021

+1

@perrotta
Copy link
Contributor

perrotta commented Dec 3, 2021

merge
(@cms-sw/l1-l2 already signed the PRs in master...)

@cmsbuild cmsbuild merged commit 01bfb2c into cms-sw:CMSSW_12_1_X Dec 3, 2021
@francescobrivio francescobrivio deleted the alca-Run3DataGTandWFs branch December 8, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants