Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temporary work around for clang 3.4 which is not parsing #3634

Merged
merged 1 commit into from May 2, 2014
Merged

temporary work around for clang 3.4 which is not parsing #3634

merged 1 commit into from May 2, 2014

Conversation

gartung
Copy link
Member

@gartung gartung commented May 1, 2014

[[cms::thread_guard(" var ")]] correctly and causing an error from clang

[[cms::thread_guard(" var ")]] correctly and causing an error from clang
@gartung gartung closed this May 1, 2014
@gartung gartung deleted the MagneticField-clang-workaround branch May 1, 2014 20:01
@gartung gartung restored the MagneticField-clang-workaround branch May 1, 2014 20:06
@gartung gartung reopened this May 1, 2014
@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2014

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_1_X.

temporary work around for clang 3.4 which is not parsing

It involves the following packages:

MagneticField/Engine

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@namapane this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2014

ktf added a commit that referenced this pull request May 2, 2014
Static Analyser -- Temporary work around for clang 3.4 which is not parsing
@ktf ktf merged commit 2d6c97b into cms-sw:CMSSW_7_1_X May 2, 2014
@ktf
Copy link
Contributor

ktf commented May 2, 2014

Bypassing Reco since this is a trivial change. Complain if not ok.

@gartung gartung deleted the MagneticField-clang-workaround branch May 2, 2014 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants