Apply Naming Rules to BeamSpotOnlineObjects methods

[francescobrivio]

PR description:

Following the discussion in #35338 (comment) I made this rather technical PR that to update the methods of BeamSpotOnlineObjects to follow CMSSW Naming Rules (specifically 2.8/2.9/2.10/2.11) so that:

• setters methods start with set*
• getters methods don't contain anymore the word get

I used git cms-checkdeps -a to modify all the packages depending on the BeamSpotOnlineObjects class.

A second PR will follow this in order to update also the methods of BeamSpotObjects.

I also profited of this PR to migrate CondTools/BeamSpot/plugins/BeamSpotOnlineRecordsWriter.cc to use an object created on the stack as suggested in this slide and part of cms-AlCaDB/AlCaTools#28.

PR validation:

Code compiles.

Backport:

Not a backport, no backport needed.

FYI: @dzuolo @lguzzi @gennai

[francescobrivio]

code-checks

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36348/27108

• This PR adds an extra 52KB to repository

[cmsbuild]

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

• CondCore/BeamSpotPlugins (db)
• CondFormats/BeamSpotObjects (db, alca)
• CondTools/BeamSpot (db, alca)
• DQM/BeamMonitor (dqm)
• RecoVertex/BeamSpotProducer (reconstruction, alca)

@malbouis, @yuanchao, @pmandrik, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @ggovi, @jfernan2, @slava77, @jpata, @francescobrivio, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @tocheng, @mmusich, @mtosi, @dgulhan, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[francescobrivio]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8817e4/20965/summary.html
COMMIT: a1e7b0b
CMSSW: CMSSW_12_2_X_2021-12-03-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36348/20965/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 41
• DQMHistoTests: Total histograms compared: 3041955
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3041927
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 40 files compared)
• Checked 175 log files, 37 edm output root files, 41 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[mmusich]

I also profited of this PR to migrate CondTools/BeamSpot/plugins/BeamSpotOnlineRecordsWriter.cc to use an object created on the stack as suggested in this slide and part of cms-AlCaDB/AlCaTools#28.

Just pointing out for the record that while that is possible here and that's the preferred choice stated in the slides, that's by no means necessary (as the current state of affairs falls in the second category enumerated in the reference slides).

[tvami]

+1

• tests pass
• code changes in line w the PR description

[jpata]

+reconstruction

• code style only in RecoVertex/BeamSpotProducer
• no differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• Technical