Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASAN] fix unit tests by setting NO_TEST_PREFIX flag for ASAN IB #36365

Merged
merged 1 commit into from Dec 7, 2021
Merged

[ASAN] fix unit tests by setting NO_TEST_PREFIX flag for ASAN IB #36365

merged 1 commit into from Dec 7, 2021

Conversation

iarspider
Copy link
Contributor

PR description:

Attempt to fix failing unit tests in ASAN builds, similar to #36249 .

@cmsbuild cmsbuild added this to the CMSSW_12_2_X milestone Dec 5, 2021
@iarspider
Copy link
Contributor Author

please test for CMSSW_12_2_ASAN_X

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36365/27130

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2021

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • CondCore/Utilities (db)

@ggovi, @malbouis, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2021

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d85e64/20996/summary.html
COMMIT: 20d8ce3
CMSSW: CMSSW_12_2_X_2021-12-04-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36365/20996/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d85e64/20996/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d85e64/20996/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test test_CondToolsSiPhase2Tracker had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 41
  • DQMHistoTests: Total histograms compared: 3041955
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3041933
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 40 files compared)
  • Checked 173 log files, 37 edm output root files, 41 DQM output files
  • TriggerResults: no differences found

@iarspider
Copy link
Contributor Author

please test for CMSSW_12_2_ASAN_X

@smuzaffar smuzaffar modified the milestones: CMSSW_12_2_X, CMSSW_12_3_X Dec 6, 2021
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2021

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d85e64/21004/summary.html
COMMIT: 20d8ce3
CMSSW: CMSSW_12_2_ASAN_X_2021-12-03-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36365/21004/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d85e64/21004/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d85e64/21004/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test testGetPayloadData had ERRORS
---> test testWriteReadAlCaRecoTriggerBits had ERRORS
---> test SiStripDCS_O2O_test had ERRORS
---> test test_CondToolsSiPhase2Tracker had ERRORS
and more ...

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • Reco comparison had 69 failed jobs
  • DQMHistoTests: Total files compared: 41
  • DQMHistoTests: Total histograms compared: 3041955
  • DQMHistoTests: Total failures: 1017681
  • DQMHistoTests: Total nulls: 65
  • DQMHistoTests: Total successes: 2024187
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.17 KiB( 40 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.117 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): -0.533 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.246 KiB SiStrip/MechanicalView
  • Checked 173 log files, 37 edm output root files, 41 DQM output files

@tvami
Copy link
Contributor

tvami commented Dec 6, 2021

Here https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d85e64/21004/unitTests/src/CondCore/Utilities/test/testGetPayloadData/testing.log

I see "==21987==ASan runtime does not come first in initial library list; you should either link runtime to your application or manually preload it with LD_PRELOAD."

@iarspider
Copy link
Contributor Author

@tvami I think this is an expected message

@tvami
Copy link
Contributor

tvami commented Dec 6, 2021

@tvami I think this is an expected message

Ah ok, so we are good then, right?

@tvami
Copy link
Contributor

tvami commented Dec 6, 2021

+db

  • bugfix PR

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Dec 7, 2021

+1
unit test errors already in IB CMSSW_12_2_ASAN_X_2021-12-03-2300

@qliphy
Copy link
Contributor

qliphy commented Dec 7, 2021

merge

@cmsbuild cmsbuild merged commit 7914cd4 into cms-sw:master Dec 7, 2021
@iarspider iarspider deleted the patch-1 branch December 7, 2021 10:21
This was referenced Dec 7, 2021
Closed
Merged
@smuzaffar smuzaffar mentioned this pull request Feb 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved db-approved fully-signed orp-approved tests-rejected
Projects
None yet
Milestone
CMSSW_12_3_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@iarspider @cmsbuild @tvami @qliphy @smuzaffar