Modernize HcalPatternSource.cc and HtrXmlPattern.cc

[tvami]

PR description:

Part of the migration in #31061

According to #31061 (comment) this is the last AlCa module missing an ES get() migration

PR validation:

Code compiles

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

cc @makortel @bsunanda

[tvami]

code-checks

[tvami]

@cmsbuild , please test

[tvami]

Hi @smuzaffar is something wrong with the bot? Code-checks take very long, looking at the list code-checks-pending I'm not alone with this

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36382/27160

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

• IORawData/CaloPatterns (alca)

@malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@simonepigazzini, @mmusich, @thomreis, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[tvami]

Hi @smuzaffar is something wrong with the bot? Code-checks take very long, looking at the list code-checks-pending I'm not alone with this

ok it worked out after 1 hour

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3b7794/21034/summary.html
COMMIT: 0524002
CMSSW: CMSSW_12_2_X_2021-12-06-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36382/21034/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_2_X_2021-12-06-2300/src/IORawData/CaloPatterns/src/HtrXmlPatternTool.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_2_X_2021-12-06-2300/src/IORawData/CaloPatterns/src/HtrXmlPatternToolParameters.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_2_X_2021-12-06-2300/src/IORawData/CaloPatterns/src/HtrXmlPatternWriter.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_2_X_2021-12-06-2300/src/IORawData/CaloPatterns/src/Module.cc
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_2_X_2021-12-06-2300/src/IORawData/CaloPatterns/src/Module.cc:1:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_2_X_2021-12-06-2300/poison/IORawData/CaloPatterns/src/HcalPatternSource.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
    1 | #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
      |  ^~~~~
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_2_X_2021-12-06-2300/src/IORawData/CaloPatterns/src/Module.cc:2:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_2_X_2021-12-06-2300/poison/IORawData/CaloPatterns/src/HtrXmlPattern.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
    1 | #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.


[tvami]

@cmsbuild , please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36382/27167

• This PR adds an extra 12KB to repository

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36382/27187

• This PR adds an extra 12KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36382/27187/code-checks.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36382/27187/code-checks.patch | patch -p1
  You can also run scram build code-checks to apply code checks directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36382/27188

• This PR adds an extra 12KB to repository

[tvami]

@cmsbuild , please test

[cmsbuild]

Pull request #36382 was updated. @cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3b7794/21058/summary.html
COMMIT: 985b9fa
CMSSW: CMSSW_12_3_X_2021-12-06-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36382/21058/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3250608
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3250580
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 41 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[malbouis]

+alca

• esConsumes migration, moved header files to .cc, moved std::cout to edm::LogPrint
• Review comments were addressed

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1