Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence file closuring printouts in StatisticsSenderService by default #36403

Merged
merged 1 commit into from Dec 8, 2021

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Dec 7, 2021

PR description:

Noticed these while working on something else. They are useful only in debugging, so silencing them by default.

PR validation:

Code compiles. A random cmsRun job that previously printed out fully closed: ... does not print it anymore.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36403/27208

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2021

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

  • Utilities/StorageFactory (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

makortel commented Dec 7, 2021

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-74efe8/21077/summary.html
COMMIT: 3e19b03
CMSSW: CMSSW_12_3_X_2021-12-07-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36403/21077/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3250608
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3250574
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor Author

makortel commented Dec 8, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Dec 8, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants