Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_0_X] Replace Candidate GT in conddb script unit tests #36418

Merged
merged 1 commit into from Dec 9, 2021

Conversation

malbouis
Copy link
Contributor

@malbouis malbouis commented Dec 8, 2021

PR description:

This is a backport of PR #36402 for the conddb script unit tests part.

It replaces a Candidate GT by a named GT in the conddb script unit tests in view of AlCaDB policy of deleting Candidates GTs older than 6 months.

PR validation:

scram b runtests_test_conddb

if this PR is a backport please specify the original PR and why you need to backport that PR:

backport of #36402

@cmsbuild cmsbuild added this to the CMSSW_12_0_X milestone Dec 8, 2021
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2021

A new Pull Request was created by @malbouis for CMSSW_12_0_X.

It involves the following packages:

  • CondCore/Utilities (db)

@cmsbuild, @ggovi, @tvami, @malbouis, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@malbouis
Copy link
Contributor Author

malbouis commented Dec 8, 2021

backport of #36402

@malbouis
Copy link
Contributor Author

malbouis commented Dec 8, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f88638/21099/summary.html
COMMIT: f6f98c8
CMSSW: CMSSW_12_0_X_2021-12-07-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36418/21099/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2998530
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Dec 8, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2021

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Dec 9, 2021

+1

  • Update of the test script is needed in view of the ConfDB policy of deleting Candidates GTs older than 6 months
  • Not clear whether it needs to stay in the release, but it can be merged anyhow just in case another 12_0_X release will be built

@cmsbuild cmsbuild merged commit ec10fa5 into cms-sw:CMSSW_12_0_X Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants