Update all other guns

[mkirsano]

PR description:

Change all remaining Pythia8 guns similarly to Py8EGun (preparation for hepmc3, PR #35700)

PR validation:

Tested by running test configuration in Pythia8Interface/test

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36420/27235

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36420/27235/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36420/27235/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36420/27238

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @mkirsano (Mikhail Kirsanov) for master.

It involves the following packages:

• GeneratorInterface/Pythia8Interface (generators)

@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@alberto-sanchez this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mkirsano]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3f47b4/21103/summary.html
COMMIT: 7d03ea6
CMSSW: CMSSW_12_3_X_2021-12-07-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36420/21103/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 14 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3250608
• DQMHistoTests: Total failures: 32
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3250553
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 41 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[mkirsano]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

@mkirsano could you please comment about the changes in the outputs of wf 1306.0 which are visible in the test results?
Since you are there, could you please add in the PR descrition a link to the previous PR intended for the "other guns"?

[mkirsano]

How can I look at the configurations in 1306? Did not find them in logs.

[perrotta]

https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_3_X_2021-12-07-2300+3f47b4/47348/validateJR.html

(that you can reach from #36420 (comment), "Comparison failed", etc.)

[qliphy]

1306 involves Pythia8PtGun [1], which is changed by this PR [2]. @mkirsano Please check whether the differences [3] are expected or not.

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3f47b4/21103/runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/SingleMuPt1_pythia8_cfi_GEN_SIM.py

[2] https://github.com/cms-sw/cmssw/blob/7d03ea6d12d8113ad9cef655a6421c55c2072eb4/GeneratorInterface/Pythia8Interface/plugins/Py8PtGun.cc

[3] https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_3_X_2021-12-07-2300+3f47b4/47348/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/Generator_Particles.html

[mkirsano]

I compared how the configuration GEN-SIM of wf1306 works, and I see no difference. The second event at the generator level is the same, which means that Geant4 had the same input in the first event (random sequence did not change). Output slightly increased because of one more particle in HepMC record (so simhits did not disappear).

[qliphy]

Output slightly increased because of one more particle in HepMC record (so simhits did not disappear).

Thanks @mkirsano Would you please elaborate more on above?

[mkirsano]

Unlike HepMC2, HepMC3 creates a record from a tree, starting from beam particle(s). In previous variant of guns there were no beam particles and no well defined tree. If HepMC3 is used, the record would be empty. This PR changes this, adding a dummy "beam" particle. Its status is not "final state" particle, so it is not taken by Geant4.

[qliphy]

+1