Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added FinalPath implementation [12_2] #36438

Merged
merged 5 commits into from Dec 11, 2021

Conversation

Dr15Jones
Copy link
Contributor

PR description:

OutputModules placed on a FinalPath do not cause unscheduled execution. This ability was requested by HLT.

As part of work, consolidated all copied code used in various OutputModuleBase implementations into one class.

Backport of #36398

PR validation:

Code compiles. All framework related unit tests (included the newly added ones) pass.

This is needed for the FinalPath implementation.
Consolidated all common code used by OutputModuleBase classes into one class.
OutputModules on FinalPaths do not cause unscheduled execution.
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2021

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_12_2_X.

It involves the following packages:

  • FWCore/Framework (core)
  • FWCore/Integration (core)
  • FWCore/Modules (core)
  • FWCore/ParameterSet (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor

makortel commented Dec 9, 2021

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-96cab1/21141/summary.html
COMMIT: 3d438da
CMSSW: CMSSW_12_2_X_2021-12-09-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36438/21141/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test testCondToolsSiStripBuildersReaders had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3250608
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3250586
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@Dr15Jones
Copy link
Contributor Author

The failure is unrelated to this PR. SQLite is reporting a disk I/O failure.

@makortel
Copy link
Contributor

The failure is unrelated to this PR. SQLite is reporting a disk I/O failure.

For the record, this error (occurring also in IBs) is reported in #36319.

@makortel
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_12_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Dec 11, 2021

merge

@cmsbuild cmsbuild merged commit ea5c1fc into cms-sw:CMSSW_12_2_X Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants