Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.2.X] Enhance PixelTrack SoA DQM monitoring #36444

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Dec 10, 2021

PR description:

This is a combined backport of #36392 and #36432.
Restructuring SiPixelPhase1MonitorTrackSoA to use the pixel track quality information, number of layers and profiles of # hits, # layers and chi2 vs track eta/phi;.

PR validation:

Run runTheMatrix.py --what gpu -l 11634.506 on a lxplus-gpu node.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This backport is needed for eventual submission of large scale RelVals for GPU vs CPU reconstruction checks in this cycle.

@mmusich
Copy link
Contributor Author

mmusich commented Dec 10, 2021

backport of #36392 and #36432

@cmsbuild cmsbuild added this to the CMSSW_12_2_X milestone Dec 10, 2021
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_2_X.

It involves the following packages:

  • DQM/SiPixelPhase1Heterogeneous (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @fioriNTU, @hdelanno, @jandrea this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Dec 10, 2021

enable gpu

@mmusich
Copy link
Contributor Author

mmusich commented Dec 10, 2021

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb02a0/21155/summary.html
COMMIT: 32c3b35
CMSSW: CMSSW_12_2_X_2021-12-09-2300/slc7_amd64_gcc900
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36444/21155/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 4
  • DQMHistoTests: Total histograms compared: 19802
  • DQMHistoTests: Total failures: 1150
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 18652
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 5.962 KiB( 3 files compared)
  • DQMHistoSizes: changed ( 11634.506 ): 5.962 KiB SiPixelHeterogeneous/PixelTrackSoA
  • Checked 12 log files, 9 edm output root files, 4 DQM output files
  • TriggerResults: no differences found

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3250608
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3250580
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Dec 11, 2021

+1

@cmsbuild cmsbuild merged commit 9b289cc into cms-sw:CMSSW_12_2_X Dec 11, 2021
@mmusich mmusich deleted the addQualityiPixelPhase1MonitorTrackSoA_12_2_X branch December 11, 2021 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants