Phase 2 tracker: add T28 and T29 (geometries with bricked pixels for IT sensor design studies) #36457

adewit · 2021-12-10T20:35:09Z

PR description:

This PR adds two new phase2 tracker layouts proposed in the IT sensors performance task force and correspond to evolutions of T27 (geometry with bricked pixels). More information [in these slides]

In particular this adds:

T28, a tracker based on T25, with 25x100 mum2 3D pixels in IT TBPX layer 1, bricked pixels in the central rod of TBPX layers 2 and 3, in the central 3 rods of TBPX layer 4, in TEPX, and in disks 5-8 of TFPX. The other pixels are planar 25x100 mum2.
T29, a tracker based on T25, with 25x100 mum2 3D pixels in IT TBPX layer 1, bricked pixels in the central rod of TBPX layers 2 and 3, in the central 3 rods of TBPX layer 4. 50x50 mum2 planar pixels are used in TFPX and TEPX.

There are no changes in the OT wrt T25.

T28 is included in geometry scenario 2026D89 and T29 in scenario 2026D90

important: we use process modifiers to account for the presence of bricked pixels, but no square pixel process modifiers are applied (even in T29). The reason for this is that with the square pixel process modifier the genErrors are used when running the CPE without track angles, but we do not have genErrors for bricked pixels.

@emiglior @tsusa @connorpa fyi

PR validation:

checked XMLs make sense wrt tracker design
checked that the workflows with scenarios D89 and D90 run smoothly with no warnings.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport

cmsbuild · 2021-12-10T21:02:09Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36457/27303

This PR adds an extra 88KB to repository
Found files with invalid states:
- Geometry/TrackerCommonData/data/PhaseII/Tracker_DD4hep_compatible_IT801_2021_12/pixelStructureTopology.xml:
  - Added: b69848c
  - Deleted: cb8fd48
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Phase 2 HLT menu targetting 7.5×10³⁴ cm⁻²s⁻¹ #35342, Phase II Patatrack Pixel Local Reco #36235, Add run3 tracking low pu era #33532

cmsbuild · 2021-12-10T21:02:32Z

A new Pull Request was created by @adewit for master.

It involves the following packages:

Configuration/Geometry (geometry, upgrade)
Configuration/PyReleaseValidation (pdmv, upgrade)
Configuration/StandardSequences (operations)
Geometry/CMSCommonData (geometry, upgrade)
Geometry/TrackerCommonData (geometry)

@perrotta, @civanch, @Dr15Jones, @jordan-martins, @makortel, @cvuosalo, @wajidalikhan, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @bbilin, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @vargasa, @makortel, @felicepantaleo, @slomeo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @bsunanda, @ebrondol, @kpedro88, @lecriste, @mmusich, @ghugo83, @mtosi, @dgulhan, @missirol, @venturia this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

mmusich · 2021-12-10T21:20:35Z

test parameters:

workflows = 39834.0, 40234.0

mmusich · 2021-12-10T21:47:43Z

@adewit

important: we use process modifiers to account for the presence of bricked pixels, but no square pixel process modifiers are applied (even in T29).

I guess you do that because otherwise you would fall in the case in which genErrors are used when the CPE is called w/o track angles and there are none for bricked pixels.

cmssw/RecoLocalTracker/SiPixelRecHits/python/PixelCPEGeneric_cfi.py

Lines 54 to 56 in a4bb3ed

    
           (phase2_tracker & (phase2_squarePixels | phase2_3DPixels)).toModify(PixelCPEGenericESProducer, 
        
                                                                               NoTemplateErrorsWhenNoTrkAngles = False # use genErrors in the seeding step (when no track angles are available) 
        
                                                                               )

If that's the case might be worth specifying in the PR description.

adewit · 2021-12-11T13:14:27Z

@adewit

important: we use process modifiers to account for the presence of bricked pixels, but no square pixel process modifiers are applied (even in T29).

I guess you do that because otherwise you would fall in the case in which genErrors are used when the CPE is called w/o track angles and there are none for bricked pixels.

cmssw/RecoLocalTracker/SiPixelRecHits/python/PixelCPEGeneric_cfi.py

Lines 54 to 56 in a4bb3ed

(phase2_tracker & (phase2_squarePixels | phase2_3DPixels)).toModify(PixelCPEGenericESProducer,

NoTemplateErrorsWhenNoTrkAngles = False # use genErrors in the seeding step (when no track angles are available)

)

If that's the case might be worth specifying in the PR description.

Yes, that is the reason. Have updated the PR description to be more specific about this.

cmsbuild · 2021-12-11T13:16:51Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36457/27307

This PR adds an extra 88KB to repository
Found files with invalid states:
- Geometry/TrackerCommonData/data/PhaseII/Tracker_DD4hep_compatible_IT801_2021_12/pixelStructureTopology.xml:
  - Added: b69848c
  - Deleted: cb8fd48
- Geometry/TrackerCommonData/data/PhaseII/Tracker_DD4hep_compatible_IT802_2021_12/pixel.xml:
  - Added: cb8fd48
  - Deleted: fb136d1
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Phase 2 HLT menu targetting 7.5×10³⁴ cm⁻²s⁻¹ #35342, Phase II Patatrack Pixel Local Reco #36235, Add run3 tracking low pu era #33532

cmsbuild · 2021-12-11T13:17:13Z

Pull request #36457 was updated. @perrotta, @civanch, @Dr15Jones, @jordan-martins, @makortel, @cvuosalo, @wajidalikhan, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @bbilin, @qliphy, @fabiocos, @davidlange6 can you please check and sign again.

mmusich · 2021-12-11T13:20:01Z

please test

cmsbuild · 2021-12-11T19:04:07Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b9b732/21202/summary.html
COMMIT: fb136d1
CMSSW: CMSSW_12_3_X_2021-12-10-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36457/21202/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b9b732/39834.0_TTbar_14TeV+2026D89+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b9b732/40234.0_TTbar_14TeV+2026D90+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 42
DQMHistoTests: Total histograms compared: 3250704
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3250682
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
Checked 177 log files, 37 edm output root files, 42 DQM output files
TriggerResults: no differences found

Configuration/PyReleaseValidation/python/relval_2026.py

perrotta · 2021-12-21T17:50:05Z

+operations

cmsbuild · 2021-12-21T17:50:24Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2021-12-21T17:53:48Z

merge
(Fixed the geometry scenario in a comment field: no need to re-test)

cmsbuild · 2021-12-21T18:04:27Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36457/27511

This PR adds an extra 16KB to repository
Found files with invalid states:
- Geometry/TrackerCommonData/data/PhaseII/Tracker_DD4hep_compatible_IT801_2021_12/pixelStructureTopology.xml:
  - Added: b69848c
  - Deleted: cb8fd48
- Geometry/TrackerCommonData/data/PhaseII/Tracker_DD4hep_compatible_IT802_2021_12/pixel.xml:
  - Added: cb8fd48
  - Deleted: fb136d1
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_2026.py modified in PR(s): Phase II Patatrack Pixel Local Reco #36235
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Phase 2 HLT menu targetting 7.5×10³⁴ cm⁻²s⁻¹ #35342, Add run3 tracking low pu era #33532, Phase II Patatrack Pixel Local Reco #36235, Remove Event Interpretation (EI) from relval steps #36465, HGCAL Pattern Recognition using FastJet #36172

cmsbuild · 2021-12-21T18:04:52Z

Pull request #36457 was updated. @perrotta, @civanch, @Dr15Jones, @jordan-martins, @makortel, @cvuosalo, @wajidalikhan, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @bbilin, @qliphy, @fabiocos, @davidlange6 can you please check and sign again.

adewit added 2 commits December 7, 2021 21:27

Adding T28 - only barrel has bricked pixels

b69848c

Modifying T28 and adding T29

cb8fd48

cmsbuild added this to the CMSSW_12_3_X milestone Dec 10, 2021

cmsbuild added code-checks-pending geometry-pending operations-pending orp-pending pdmv-pending pending-signatures tests-pending upgrade-pending labels Dec 10, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 10, 2021

Correction in T28: should use same pixel.xml at T27

fb136d1

cmsbuild added code-checks-pending and removed code-checks-approved labels Dec 11, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 11, 2021

cmsbuild added tests-started and removed tests-pending labels Dec 11, 2021

cmsbuild removed the tests-started label Dec 11, 2021

perrotta reviewed Dec 21, 2021

View reviewed changes

Configuration/PyReleaseValidation/python/relval_2026.py Outdated Show resolved Hide resolved

cmsbuild removed operations-pending pending-signatures labels Dec 21, 2021

cmsbuild added fully-signed operations-approved labels Dec 21, 2021

Fix geometry scenario in the comment field

10ac102

cmsbuild added code-checks-pending geometry-pending operations-pending pdmv-pending pending-signatures tests-pending upgrade-pending and removed geometry-approved operations-approved fully-signed tests-approved pdmv-approved upgrade-approved code-checks-approved labels Dec 21, 2021

cmsbuild added orp-approved and removed orp-pending labels Dec 21, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 21, 2021

cmsbuild merged commit 1d3499a into cms-sw:master Dec 21, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Phase 2 tracker: add T28 and T29 (geometries with bricked pixels for IT sensor design studies) #36457

Phase 2 tracker: add T28 and T29 (geometries with bricked pixels for IT sensor design studies) #36457

adewit commented Dec 10, 2021 •

edited

cmsbuild commented Dec 10, 2021

cmsbuild commented Dec 10, 2021

mmusich commented Dec 10, 2021

mmusich commented Dec 10, 2021

adewit commented Dec 11, 2021

cmsbuild commented Dec 11, 2021

cmsbuild commented Dec 11, 2021

mmusich commented Dec 11, 2021

cmsbuild commented Dec 11, 2021

perrotta commented Dec 21, 2021

cmsbuild commented Dec 21, 2021

perrotta commented Dec 21, 2021

cmsbuild commented Dec 21, 2021

cmsbuild commented Dec 21, 2021

Phase 2 tracker: add T28 and T29 (geometries with bricked pixels for IT sensor design studies) #36457

Phase 2 tracker: add T28 and T29 (geometries with bricked pixels for IT sensor design studies) #36457

Conversation

adewit commented Dec 10, 2021 • edited

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Dec 10, 2021

cmsbuild commented Dec 10, 2021

mmusich commented Dec 10, 2021

mmusich commented Dec 10, 2021

adewit commented Dec 11, 2021

cmsbuild commented Dec 11, 2021

cmsbuild commented Dec 11, 2021

mmusich commented Dec 11, 2021

cmsbuild commented Dec 11, 2021

Comparison Summary

perrotta commented Dec 21, 2021

cmsbuild commented Dec 21, 2021

perrotta commented Dec 21, 2021

cmsbuild commented Dec 21, 2021

cmsbuild commented Dec 21, 2021

adewit commented Dec 10, 2021 •

edited