Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shashlik detId extension #3647

Merged

Conversation

fratnikov
Copy link

-Extend Shashlik DetId by geometrical ID and loose hash index
-Define dictionaries for all EKDetId related objects

-Define dictionaries for all EKDetId related objects
@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2014

A new Pull Request was created by @fratnikov (Fedor Ratnikov) for CMSSW_6_2_X_SLHC.

Shashlik detId extension

It involves the following packages:

DataFormats/EcalDetId

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@fratnikov
Copy link
Author

Changes are pure extensions.
These extensions are necessary for coming Shashlik RECO geometry deployment.
Ianna is on vacations, so probably somebody could sign off instead.

@ktf
Copy link
Contributor

ktf commented May 3, 2014

For the record I got clear indication from Ianna that this PR should go in even if she is on vacation. @davidlange6 any objections?

@mark-grimes
Copy link

merge

Bypassing the geometry signature for this.
Tests 10000, 10200, 10400, 11200, 11400, 12000, 12800, 13000, 13600 and 14600 pass all steps.
Tests 12400, 12600, 13800 and 14000 fail in step 2 with known errors.
Tests 12200 and 14400 fail in step 3 with known errors. 14200 crashed in step 3 with a different error (below) to the one I usually get, but I got this before merging this pull request.

#5  0x00002b8a044c3068 in ECAL2DPositionCalcWithDepthCorr::update(edm::EventSetup const&) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-05-04-0200/lib/slc5_amd64_gcc472/libRecoParticleFlowPFClusterProducer.so
#6  0x00002b8a044730c3 in PFClusterProducer::beginLuminosityBlock(edm::LuminosityBlock const&, edm::EventSetup const&) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-05-04-0200/lib/slc5_amd64_gcc472/pluginRecoParticleFlowPFClusterProducerPlugins.so
#7  0x00002b89dd70b0a0 in edm::EDProducer::doBeginLuminosityBlock(edm::LuminosityBlockPrincipal&, edm::EventSetup const&, edm::CurrentProcessingContext const*) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-05-04-0200/lib/slc5_amd64_gcc472/libFWCoreFramework.so

cmsbuild added a commit that referenced this pull request May 5, 2014
@cmsbuild cmsbuild merged commit fd45b5f into cms-sw:CMSSW_6_2_X_SLHC May 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants