Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove tcMet from the event contents of RECO and AOD #3650

Merged
merged 6 commits into from May 7, 2014

Conversation

TaiSakuma
Copy link
Contributor

As we discussed at the RECO meeting on 17-Apr-2014: https://indico.cern.ch/event/313948/contribution/18, I am trying to remove tcMet from the event contents of RECO and AOD.

This PR simply removes tcMet and its related value map from the event contents.

However, it fails one of the matrix tests:

runTheMatrix.py -l 1000.0

It fails at step3.

I don't know exactly how to fix it. I think that many files under
https://github.com/cms-sw/cmssw/tree/CMSSW_7_1_0_pre7/Configuration/Skimming/test/tier1
need to be modified.

I am not very familiar with files in Configuration/Skimming. Is it ok for me to make the changes in Configuration/Skimming and pull requests?

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2014

A new Pull Request was created by @TaiSakuma (Tai Sakuma) for CMSSW_7_1_X.

remove tcMet from the event contents of RECO and AOD

It involves the following packages:

RecoMET/Configuration

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@nhanvtran this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@TaiSakuma
Copy link
Contributor Author

What I wrote about Configuration/Skimming was wrong. It was not necessary to edit any file under Configuration/Skimming.

I had to modify DPGAnalysis/Skims/python/Skims_DPG_cff.py.

The matrix tests pass now.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2014

Pull request #3650 was updated. @nclopezo, @vlimant, @franzoni, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2014

-1
When I ran the RelVals I found an error in the following worklfows:
50101.0 step2

runTheMatrix-results/50101.0_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID/step2_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID.log
----- Begin Fatal Exception 04-May-2014 00:02:03 CEST-----------------------
An exception of category 'InvalidReference' occurred while
   [0] Processing run: 1 lumi: 5 event: 12001
   [1] Running path 'validation_step'
   [2] Calling event method for module METTester/'tcMetAnalyzer'
Exception Message:
ValueMap: no associated value for given product and index
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3650/1260/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2014

Pull request #3650 was updated. @thspeer, @vlimant, @franzoni, @anton-a, @slava77, @davidlange6 can you please check and sign again.

@TaiSakuma
Copy link
Contributor Author

with TaiSakuma@3fc8961

runTheMatrix.py -l 50101.0

passes

@TaiSakuma
Copy link
Contributor Author

I looked at the log files of 4.22 and 1003.0. The errors occurred because the DAS queries in the matrix returned empty results. I assume that I don't have to modify my PR.

@davidlange6
Copy link
Contributor

+1
for operations

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2014

@anton-a
Copy link

anton-a commented May 7, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request May 7, 2014
Reco -- Remove tcMet from the event contents of RECO and AOD
@ktf ktf merged commit 59fc48c into cms-sw:CMSSW_7_1_X May 7, 2014
@vadler vadler mentioned this pull request May 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants