New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop type specs in RecoTau and RecoVertex #36511
Changes from 1 commit
89b3e72
c5891c6
efcf44a
86df6b2
ff4627b
fc1015e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -2,46 +2,46 @@ | |||||||||||
|
||||||||||||
from Validation.RecoVertex.PrimaryVertexAnalyzer4PUSlimmed_cfi import * | ||||||||||||
|
||||||||||||
hltMultiPVanalysis = vertexAnalysis.clone() | ||||||||||||
hltMultiPVanalysis.do_generic_sim_plots = False | ||||||||||||
hltMultiPVanalysis.verbose = cms.untracked.bool(False) | ||||||||||||
hltMultiPVanalysis.root_folder = cms.untracked.string("HLT/Vertexing/ValidationWRTsim") | ||||||||||||
hltMultiPVanalysis.vertexRecoCollections = cms.VInputTag( ) | ||||||||||||
hltMultiPVanalysis.trackAssociatorMap = cms.untracked.InputTag("trackingParticleRecoTrackAsssociation") | ||||||||||||
hltMultiPVanalysis.vertexAssociator = cms.untracked.InputTag("VertexAssociatorByPositionAndTracks") | ||||||||||||
|
||||||||||||
hltMultiPVanalysis = vertexAnalysis.clone( | ||||||||||||
do_generic_sim_plots = False, | ||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Some tabbing would improve readability |
||||||||||||
verbose = False, | ||||||||||||
root_folder = "HLT/Vertexing/ValidationWRTsim", | ||||||||||||
vertexRecoCollections = ("",), | ||||||||||||
NiharSaha marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||||
trackAssociatorMap = "trackingParticleRecoTrackAsssociation", | ||||||||||||
vertexAssociator = "VertexAssociatorByPositionAndTracks" | ||||||||||||
) | ||||||||||||
from Validation.RecoTrack.associators_cff import hltTrackAssociatorByHits, tpToHLTpixelTrackAssociation | ||||||||||||
from SimTracker.VertexAssociation.VertexAssociatorByPositionAndTracks_cfi import VertexAssociatorByPositionAndTracks as _VertexAssociatorByPositionAndTracks | ||||||||||||
vertexAssociatorByPositionAndTracks4pixelTracks = _VertexAssociatorByPositionAndTracks.clone() | ||||||||||||
vertexAssociatorByPositionAndTracks4pixelTracks.trackAssociation = cms.InputTag("tpToHLTpixelTrackAssociation") | ||||||||||||
|
||||||||||||
vertexAssociatorByPositionAndTracks4pixelTracks = _VertexAssociatorByPositionAndTracks.clone( | ||||||||||||
trackAssociation = "tpToHLTpixelTrackAssociation" | ||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please tab |
||||||||||||
) | ||||||||||||
tpToHLTpfMuonMergingTrackAssociation = tpToHLTpixelTrackAssociation.clone( | ||||||||||||
label_tr = "hltPFMuonMerging" | ||||||||||||
) | ||||||||||||
vertexAssociatorByPositionAndTracks4pfMuonMergingTracks = _VertexAssociatorByPositionAndTracks.clone() | ||||||||||||
vertexAssociatorByPositionAndTracks4pfMuonMergingTracks.trackAssociation = cms.InputTag("tpToHLTpfMuonMergingTrackAssociation") | ||||||||||||
|
||||||||||||
vertexAssociatorByPositionAndTracks4pfMuonMergingTracks = _VertexAssociatorByPositionAndTracks.clone( | ||||||||||||
trackAssociation = "tpToHLTpfMuonMergingTrackAssociation" | ||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please tab (etc: the same everywhere else) |
||||||||||||
) | ||||||||||||
|
||||||||||||
|
||||||||||||
hltPixelPVanalysis = hltMultiPVanalysis.clone() | ||||||||||||
hltPixelPVanalysis.do_generic_sim_plots = True | ||||||||||||
hltPixelPVanalysis.trackAssociatorMap = cms.untracked.InputTag("tpToHLTpixelTrackAssociation") | ||||||||||||
hltPixelPVanalysis.vertexAssociator = cms.untracked.InputTag("vertexAssociatorByPositionAndTracks4pixelTracks") | ||||||||||||
hltPixelPVanalysis.vertexRecoCollections = cms.VInputTag( | ||||||||||||
hltPixelPVanalysis = hltMultiPVanalysis.clone( | ||||||||||||
do_generic_sim_plots = True, | ||||||||||||
trackAssociatorMap = "tpToHLTpixelTrackAssociation", | ||||||||||||
vertexAssociator = "vertexAssociatorByPositionAndTracks4pixelTracks", | ||||||||||||
vertexRecoCollections = ( | ||||||||||||
"hltPixelVertices", | ||||||||||||
"hltTrimmedPixelVertices", | ||||||||||||
) | ||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||
) | ||||||||||||
|
||||||||||||
|
||||||||||||
|
||||||||||||
hltPVanalysis = hltMultiPVanalysis.clone() | ||||||||||||
hltPVanalysis.trackAssociatorMap = cms.untracked.InputTag("tpToHLTpfMuonMergingTrackAssociation") | ||||||||||||
hltPVanalysis.vertexAssociator = cms.untracked.InputTag("vertexAssociatorByPositionAndTracks4pfMuonMergingTracks") | ||||||||||||
hltPVanalysis.vertexRecoCollections = cms.VInputTag( | ||||||||||||
"hltVerticesPFFilter" | ||||||||||||
hltPVanalysis = hltMultiPVanalysis.clone( | ||||||||||||
trackAssociatorMap = "tpToHLTpfMuonMergingTrackAssociation", | ||||||||||||
vertexAssociator = "vertexAssociatorByPositionAndTracks4pfMuonMergingTracks", | ||||||||||||
vertexRecoCollections = ( | ||||||||||||
"hltVerticesPFFilter", | ||||||||||||
# "hltFastPVPixelVertices" | ||||||||||||
) | ||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
(or, even better, remove the commented out part if not needed any more) |
||||||||||||
|
||||||||||||
) | ||||||||||||
hltMultiPVAssociations = cms.Task( | ||||||||||||
hltTrackAssociatorByHits, | ||||||||||||
tpToHLTpixelTrackAssociation, | ||||||||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,12 +6,12 @@ | |
filter = cms.bool(False) | ||
) | ||
|
||
selectedOfflinePrimaryVerticesWithBS = selectedOfflinePrimaryVertices.clone() | ||
selectedOfflinePrimaryVerticesWithBS.src = cms.InputTag('offlinePrimaryVerticesWithBS') | ||
|
||
selectedPixelVertices = selectedOfflinePrimaryVertices.clone() | ||
selectedPixelVertices.src = cms.InputTag('pixelVertices') | ||
|
||
selectedOfflinePrimaryVerticesWithBS = selectedOfflinePrimaryVertices.clone( | ||
src = 'offlinePrimaryVerticesWithBS' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. tab |
||
) | ||
selectedPixelVertices = selectedOfflinePrimaryVertices.clone( | ||
src = 'pixelVertices' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. tab |
||
) | ||
from DQMServices.Core.DQMEDAnalyzer import DQMEDAnalyzer | ||
vertexAnalysis = DQMEDAnalyzer('PrimaryVertexAnalyzer4PUSlimmed', | ||
use_only_charged_tracks = cms.untracked.bool(True), | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not this one?