Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made class static a member of PFCheckHitPattern #3652

Merged

Conversation

Dr15Jones
Copy link
Contributor

Had to make a static std::map to be a member data of PFCheckHitPattern
to fix a crash in the threaded framework.

Had to make a static std::map to be a member data of PFCheckHitPattern
to fix a crash in the threaded framework.
@Dr15Jones
Copy link
Contributor Author

This fixes a crash in the CMSSW_7_1_THREADED_X_2014-05-02-0200 IB.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2014

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X.

Made class static a member of PFCheckHitPattern

It involves the following packages:

RecoParticleFlow/PFTracking

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@bachtis, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2014

@anton-a
Copy link

anton-a commented May 5, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request May 5, 2014
…Pattern

Reco -- Made class static a member of PFCheckHitPattern
@ktf ktf merged commit 6879706 into cms-sw:CMSSW_7_1_X May 5, 2014
@Dr15Jones Dr15Jones deleted the makeStaticAMemberOfPFCheckHitPattern branch May 6, 2014 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants