MTD reconstruction: Implementation of MTDTrayBarrelLayer::groupedCompatibleDets()

[fabiocos]

PR description:

The MTDTrayBarrelLayer class misses a real implementation of the groupedCompatibleDets method, which is invoked during the track building. This simple implementation removes the warning messages while running Phase2 reconstruction with the alternative navigation school where MTD is added, and allows the code to fail (as it should) because the CKF does not find a MeasurementDet in MeasurementTracker compatible with BTL layers:

----- Begin Fatal Exception 16-Dec-2021 17:10:29 CET-----------------------
An exception of category 'MeasurementDet not found' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'dqmofflineOnPAT_1_step'
   [2] Prefetching for module SingleTopTChannelLeptonDQM_miniAOD/'singleTopElectronMediumDQM_miniAOD'
   [3] Prefetching for module PATMuonSlimmer/'slimmedMuons'
   [4] Prefetching for module PATMuonSelector/'selectedPatMuons'
   [5] Prefetching for module PATMuonProducer/'patMuons'
   [6] Prefetching for module MuonProducer/'muons'
   [7] Prefetching for module MuonIdProducer/'muons1stStep'
   [8] Prefetching for module DuplicateListMerger/'generalTracks'
   [9] Prefetching for module TrackProducer/'mergedDuplicateTracks'
   [10] Prefetching for module DuplicateTrackMerger/'duplicateTrackCandidates'
   [11] Prefetching for module TrackListMerger/'preDuplicateMergingGeneralTracks'
   [12] Prefetching for module TrackListMerger/'earlyGeneralTracks'
   [13] Prefetching for module MultiTrackSelector/'initialStepSelector'
   [14] Prefetching for module TrackProducer/'initialStepTracks'
   [15] Calling method for module CkfTrackCandidateMaker/'initialStepTrackCandidates'
----- End Fatal Exception -------------------------------------------------

PR validation:

This code is not called in usual workflows, where MTD is not part of the tracking navigation school. The implementation is a straightforward copy of the forward counterpart, without the need of different groups.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36525/27417

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

• RecoMTD/DetLayers (upgrade, reconstruction)

@clacaputo, @cmsbuild, @AdrianoDee, @srimanob, @slava77, @jpata can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6b7f8e/21330/summary.html
COMMIT: 2374b32
CMSSW: CMSSW_12_3_X_2021-12-16-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36525/21330/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3250719
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3250697
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[slava77]

+reconstruction

for #36525 2374b32

• code changes are in line with the PR description and with a similar implementation in MTDRingForwardDoubleLayer.cc, which was already in the ~original PR MTD Tracking Part 1 - Topology, Geometry, and Tracking Geometry #24285 in Sep 2018
• jenkins tests pass and comparisons with the baseline show no differences (this part of the code is not called in the tested workflows)

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1