HCAL: Remove 4th depth from trigger primitive sum over depths, for |ieta| = 16

[Michael-Krohn]

PR description:

Zeroing the 4th depth in the trigger towers where |ieta| = 16. This is done to match the behavior in the uHTR firmware, where the 4th depth is not included in the sum over depths when constructing the TP energy for these towers. The 4th depth is the last depth in these towers and comes from HE, whereas the first 3 come from the HB. This has been discussed in the HCAL Ops gitlab issue.

PR validation:

A basic technical test was performed: runTheMatrix.py -l limited -i all --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36528/27423

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36528/27423/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36528/27423/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36528/27430

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36528/27430/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36528/27430/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36528/27431

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @Michael-Krohn for master.

It involves the following packages:

• CalibCalorimetry/HcalTPGAlgos (l1, alca)

@malbouis, @yuanchao, @epalencia, @cmsbuild, @rekovic, @tvami, @cecilecaillol, @francescobrivio can you please review it and eventually sign? Thanks.
@bsunanda, @mmusich, @abdoulline, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-55c2fe/21339/summary.html
COMMIT: 6299f09
CMSSW: CMSSW_12_3_X_2021-12-16-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36528/21339/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2857 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3250719
• DQMHistoTests: Total failures: 2656
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3248041
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: found differences in 1 / 41 workflows

[tvami]

+alca

• tests diffs are coming from other PRs, but we already tested this in the previous (now closed PR), so I'm ok signing it

[cecilecaillol]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[abdoulline]

Can't help wondering what might have provoked so massive and certainly unrelated to this PR changes in wf 11634.7 ?

[tvami]

I'm not totally sure which PR is the origin, but I see the same diffs in https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_3_X_2021-12-16-1100+c3b61b/47525/11634.7_TTbar_14TeV+2021_trackingMkFit+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano/

Probably some mkFit related update?

[perrotta]

Can't help wondering what might have provoked so massive and certainly unrelated to this PR changes in wf 11634.7 ?

See #35109

[abdoulline]

@tvami @perrotta thanks!

[perrotta]

+1

• As agreed by HCAL Ops and other stakeholders