New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DD4hep] Follow-up to #36496 -- Update versions of materials files in unit tests #36549
Conversation
@@ -25,7 +25,7 @@ | |||
</ConstantsSection> | |||
|
|||
<IncludeSection> | |||
<Include ref="Geometry/CMSCommonData/data/materials.xml"/> | |||
<Include ref="Geometry/CMSCommonData/data/materials/2021/v1/materials.xml"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v1
instead of v3
is needed by some of the other XML files used here.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36549/27479
|
A new Pull Request was created by @cvuosalo (Carl Vuosalo) for master. It involves the following packages:
@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @clacaputo, @slava77, @jpata can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c8d1c6/21389/summary.html Comparison SummarySummary:
|
type bugfix |
+1 |
+reconstruction
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Two data files used in unit tests were omitted from #36496, which prohibits out-of-order definitions of composite materials used in geometry. In these two files, versions of the materials files needed to be updated and placed in the correct order.
PR validation:
The affected unit tests now run successfully.
No backport is needed.