Drop type specs for L1TMonitor and L1TMonitorClient #36588

NiharSaha · 2021-12-24T15:15:47Z

PR description:

Drop type specs in DQM/L1TMonitor, DQM/L1TMonitorClient python configuration files.

Central DQM migration campaign for drop type spces following
https://cms-sw.github.io/cms_coding_rules.html#6--packaging-rules-1
and update the safer syntax for existing parameters like: (1) drop type specifications where the original parameter exists. (2) using "clone" instead of "deepcopy" (3) move all parameters inside the clone

PR validation:

runTheMatrix.py -l limited -i all --ibeos

cmsbuild · 2021-12-24T15:23:32Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36588/27554

This PR adds an extra 28KB to repository

cmsbuild · 2021-12-24T15:23:54Z

A new Pull Request was created by @NiharSaha (Nihar Ranjan Saha) for master.

It involves the following packages:

DQM/L1TMonitor (dqm)
DQM/L1TMonitorClient (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

jfernan2 · 2021-12-24T16:02:45Z

DQM/L1TMonitor/python/L1TEmulatorMonitor_cff.py

-l1TdeRCTfromRCT.HistFolder = cms.untracked.string('L1TEMU/L1TdeRCT_FromRCT')
-
+l1TdeRCTRun1 = l1TdeRCT.clone(
+rctSourceData = 'caloStage1Digis',


this change is not the same: l1TdeRCTRun1 should be a frs clone of l1TdeRCT and then the pvalues of l1TdeRCT should be changed, please leave as it was

Okay, Thanks. Updated as it was in the new commit.

jfernan2 · 2021-12-24T16:03:07Z

DQM/L1TMonitor/python/L1TMonitor_cff.py

-l1tRctfromRCT.HistFolder = cms.untracked.string('L1T/L1TRCT_FromRCT')
-
+l1tRctRun1 = l1tRct.clone(
+rctSource = 'caloStage1Digis',


same as before

cmsbuild · 2021-12-24T17:38:24Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36588/27558

This PR adds an extra 32KB to repository

cmsbuild · 2021-12-24T17:38:49Z

Pull request #36588 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

jfernan2 · 2021-12-25T10:16:45Z

please test

cmsbuild · 2021-12-25T14:18:26Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a70c32/21469/summary.html
COMMIT: 78fa11b
CMSSW: CMSSW_12_3_X_2021-12-24-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36588/21469/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 43
DQMHistoTests: Total histograms compared: 3459046
DQMHistoTests: Total failures: 237
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3458786
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -2605.568 KiB( 42 files compared)
DQMHistoSizes: changed ( 10024.0,... ): -151.212 KiB L1TEMU/L1TdeStage2uGMT
DQMHistoSizes: changed ( 10024.0,... ): -0.225 KiB L1TEMU/L1TdeStage2uGT
DQMHistoSizes: changed ( 11634.0,... ): -155.661 KiB L1TEMU/L1TdeStage2uGMT
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 181 log files, 42 edm output root files, 43 DQM output files
TriggerResults: no differences found

jfernan2 · 2021-12-26T10:27:28Z

DQM/L1TMonitor/python/L1TdeStage2uGMT_cff.py

+muonCollection2 = (emulatorModule, "imdMuonsBMTF")
+monitorDir = ugmtEmuImdMuDqmDir+"/BMTF/data_vs_emulator_comparison"
+summaryTitle = "Summary of uGMT intermediate muon from BMTF comparison between unpacked and emulated"
+ignoreBin = cms.untracked.vint32(ignoreBins)


can this type be dropped?

I think it can't be dropped as it is not already defined. While I tried to remove type it was showing error.

Yes. You can define a default value in l1tdeStage2uGMT (empty vector), so that it can be modified everywhere else; or alternatively let the type specified, as it is now (not to be preferred, though)

jfernan2 · 2021-12-26T10:27:35Z

DQM/L1TMonitor/python/L1TdeStage2uGMT_cff.py

+muonCollection2 = (emulatorModule, "imdMuonsOMTFNeg")
+monitorDir = (ugmtEmuImdMuDqmDir+"/OMTF_neg/data_vs_emulator_comparison")
+summaryTitle = ("Summary of uGMT intermediate muon from OMTF- comparison between unpacked and emulated")
+ignoreBin = cms.untracked.vint32(ignoreBins)


can this type be dropped?

jfernan2 · 2021-12-26T10:27:51Z

DQM/L1TMonitor/python/L1TdeStage2uGMT_cff.py

+muonCollection2 = (emulatorModule, "imdMuonsOMTFPos")
+monitorDir = (ugmtEmuImdMuDqmDir+"/OMTF_pos/data_vs_emulator_comparison")
+summaryTitle = "Summary of uGMT intermediate muon from OMTF+ comparison between unpacked and emulated"
+ignoreBin = cms.untracked.vint32(ignoreBins)


can this type be dropped?

cmsbuild · 2021-12-31T16:58:56Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a70c32/21508/summary.html
COMMIT: 11a4f35
CMSSW: CMSSW_12_3_X_2021-12-31-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36588/21508/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 43
DQMHistoTests: Total histograms compared: 3461624
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3461596
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -3.825 KiB( 42 files compared)
DQMHistoSizes: changed ( 10024.0,... ): -0.225 KiB L1TEMU/L1TdeStage2uGT
Checked 181 log files, 42 edm output root files, 43 DQM output files
TriggerResults: no differences found

cmsbuild · 2022-01-04T07:33:42Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36588/27624

This PR adds an extra 16KB to repository

cmsbuild · 2022-01-04T07:34:05Z

Pull request #36588 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

jfernan2 · 2022-01-04T08:49:06Z

please test

cmsbuild · 2022-01-04T12:22:10Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a70c32/21523/summary.html
COMMIT: 9293a2f
CMSSW: CMSSW_12_3_X_2022-01-03-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36588/21523/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 43
DQMHistoTests: Total histograms compared: 3461692
DQMHistoTests: Total failures: 11
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3461658
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 42 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 181 log files, 42 edm output root files, 43 DQM output files
TriggerResults: no differences found

jfernan2 · 2022-01-04T12:35:25Z

+1

cmsbuild · 2022-01-04T12:35:51Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2022-01-04T13:11:56Z

+1

Drop type specs for L1TMonitor and L1TMonitorClient

035c418

cmsbuild added this to the CMSSW_12_3_X milestone Dec 24, 2021

cmsbuild added code-checks-pending dqm-pending orp-pending pending-signatures tests-pending labels Dec 24, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 24, 2021

jfernan2 reviewed Dec 24, 2021

View reviewed changes

Update L1TEmulatorMonitor_cff.py

d3eba7c

cmsbuild added code-checks-pending and removed code-checks-approved labels Dec 24, 2021

Update L1TMonitor_cff.py

78fa11b

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 24, 2021

cmsbuild added tests-started and removed tests-pending labels Dec 25, 2021

cmsbuild added tests-approved and removed tests-started labels Dec 25, 2021

jfernan2 reviewed Dec 26, 2021

View reviewed changes

cmsbuild added tests-started and removed tests-pending labels Dec 31, 2021

cmsbuild added tests-approved and removed tests-started labels Dec 31, 2021

Update L1TStage2uGTEmulatorClient_cff.py

9293a2f

cmsbuild added code-checks-pending tests-pending and removed tests-approved code-checks-approved labels Jan 4, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 4, 2022

cmsbuild added tests-started and removed tests-pending labels Jan 4, 2022

cmsbuild added tests-approved and removed tests-started labels Jan 4, 2022

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jan 4, 2022

cmsbuild added orp-approved and removed orp-pending labels Jan 4, 2022

cmsbuild merged commit ca33c02 into cms-sw:master Jan 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drop type specs for L1TMonitor and L1TMonitorClient #36588

Drop type specs for L1TMonitor and L1TMonitorClient #36588

NiharSaha commented Dec 24, 2021

cmsbuild commented Dec 24, 2021

cmsbuild commented Dec 24, 2021

jfernan2 Dec 24, 2021

NiharSaha Dec 24, 2021

jfernan2 Dec 24, 2021

cmsbuild commented Dec 24, 2021

cmsbuild commented Dec 24, 2021

jfernan2 commented Dec 25, 2021

cmsbuild commented Dec 25, 2021

jfernan2 Dec 26, 2021

NiharSaha Dec 31, 2021

perrotta Dec 31, 2021

jfernan2 Dec 26, 2021

jfernan2 Dec 26, 2021

cmsbuild commented Dec 31, 2021

cmsbuild commented Jan 4, 2022

cmsbuild commented Jan 4, 2022

jfernan2 commented Jan 4, 2022

cmsbuild commented Jan 4, 2022

jfernan2 commented Jan 4, 2022

cmsbuild commented Jan 4, 2022

qliphy commented Jan 4, 2022

Drop type specs for L1TMonitor and L1TMonitorClient #36588

Drop type specs for L1TMonitor and L1TMonitorClient #36588

Conversation

NiharSaha commented Dec 24, 2021

PR description:

PR validation:

cmsbuild commented Dec 24, 2021

cmsbuild commented Dec 24, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cmsbuild commented Dec 24, 2021

cmsbuild commented Dec 24, 2021

jfernan2 commented Dec 25, 2021

cmsbuild commented Dec 25, 2021

Comparison Summary

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cmsbuild commented Dec 31, 2021

Comparison Summary

cmsbuild commented Jan 4, 2022

cmsbuild commented Jan 4, 2022

jfernan2 commented Jan 4, 2022

cmsbuild commented Jan 4, 2022

Comparison Summary

jfernan2 commented Jan 4, 2022

cmsbuild commented Jan 4, 2022

qliphy commented Jan 4, 2022