Fixing Phase-II Patatrack Failures #36607

AdrianoDee · 2021-12-28T16:29:51Z

Fixing failures in

tests in TrackingRecHit2DCUDA_t in Unit test failure in TrackingRecHit2DCUDA_t #36605
wf 39434.502 due to esconsumes missing in SiPixelPhase2DigiToClusterCUDA Attempt to get ES data using an invalid token in SiPixelPhase2DigiToClusterCUDA #36604

AdrianoDee · 2021-12-28T16:30:59Z

@makortel this should fix both issues, thanks for spotting and reporting them!

cmsbuild · 2021-12-28T16:36:41Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36607/27581

This PR adds an extra 16KB to repository

cmsbuild · 2021-12-28T16:37:04Z

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

CUDADataFormats/TrackingRecHit (heterogeneous, reconstruction)
RecoLocalTracker/SiPixelClusterizer (reconstruction)

@makortel, @slava77, @clacaputo, @cmsbuild, @fwyzard, @jpata can you please review it and eventually sign? Thanks.
@mtosi, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @OzAmram, @ferencek, @dkotlins, @gpetruc, @mmusich, @threus, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

AdrianoDee · 2021-12-28T16:42:02Z

test parameters:

workflows = 39434.501,39434.502,39434.5

AdrianoDee · 2021-12-28T16:42:34Z

type bug-fix

AdrianoDee · 2021-12-28T16:42:39Z

please test

cmsbuild · 2021-12-28T22:04:35Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4e66d2/21490/summary.html
COMMIT: 4184826
CMSSW: CMSSW_12_3_X_2021-12-28-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36607/21490/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-4e66d2/39434.501_TTbar_14TeV+2026D88_Patatrack_PixelOnlyCPU+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-4e66d2/39434.502_TTbar_14TeV+2026D88_Patatrack_PixelOnlyGPU+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-4e66d2/39434.5_TTbar_14TeV+2026D88_pixelTrackingOnly+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 43
DQMHistoTests: Total histograms compared: 3461692
DQMHistoTests: Total failures: 11
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3461658
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 42 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 181 log files, 42 edm output root files, 43 DQM output files
TriggerResults: no differences found

slava77 · 2021-12-29T14:23:56Z

CUDADataFormats/TrackingRecHit/test/TrackingRecHit2DCUDA_t.cpp

    cudaStreamSynchronize(stream);
    assert(tkhitH.view());
    assert(tkhitH.view()->nHits() == unsigned(nHits));
-    assert(tkhitH.view()->nMaxModules() == unsigned(nModules));
+    assert(tkhitH.view()->nMaxModules() == 1856);


shouldn't this be phase1PixelTopology::numberOfModules?
Similar for the phase2 case below

- tests in TrackingRecHit2DCUDA_t - wf 39434.502 due to esconsumes in SiPixelPhase2DigiToClusterCUDA - including pixelTopology constants

cmsbuild · 2021-12-30T12:15:16Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36607/27594

This PR adds an extra 12KB to repository

cmsbuild · 2021-12-30T12:15:39Z

Pull request #36607 was updated. @makortel, @slava77, @clacaputo, @cmsbuild, @fwyzard, @jpata can you please check and sign again.

AdrianoDee · 2021-12-30T12:15:54Z

please test

cmsbuild · 2021-12-30T15:46:22Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4e66d2/21505/summary.html
COMMIT: 5179447
CMSSW: CMSSW_12_3_X_2021-12-30-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36607/21505/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-4e66d2/39434.501_TTbar_14TeV+2026D88_Patatrack_PixelOnlyCPU+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-4e66d2/39434.502_TTbar_14TeV+2026D88_Patatrack_PixelOnlyGPU+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-4e66d2/39434.5_TTbar_14TeV+2026D88_pixelTrackingOnly+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 43
DQMHistoTests: Total histograms compared: 3461692
DQMHistoTests: Total failures: 10
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3461659
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 42 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 181 log files, 42 edm output root files, 43 DQM output files
TriggerResults: no differences found

slava77 · 2021-12-30T17:24:47Z

+reconstruction

for #36607 5179447

code changes are in line with the PR description and the details/discussion in the related issues Attempt to get ES data using an invalid token in SiPixelPhase2DigiToClusterCUDA #36604 and Unit test failure in TrackingRecHit2DCUDA_t #36605
jenkins tests pass, including the affected workflows/tests and comparisons with the baseline show no (relevant) differences
- tests with GPU enabled were not submitted, but the fixes appear correct in the GPU context anyways

mmusich · 2022-01-10T12:43:45Z

urgent

mmusich · 2022-01-10T12:43:57Z

can @cms-sw/heterogeneous-l2 please have a look?

fwyzard · 2022-01-10T12:59:49Z

as soon as I'm no longer ill ...

makortel · 2022-01-10T14:31:35Z

+heterogeneous

cmsbuild · 2022-01-10T14:31:59Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

fwyzard · 2022-01-10T14:32:37Z

thanks @makortel 👍

perrotta · 2022-01-10T14:56:47Z

+1

cmsbuild added this to the CMSSW_12_3_X milestone Dec 28, 2021

cmsbuild added code-checks-pending heterogeneous-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Dec 28, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 28, 2021

cmsbuild added bug-fix tests-started and removed tests-pending labels Dec 28, 2021

cmsbuild added tests-approved and removed tests-started labels Dec 28, 2021

slava77 reviewed Dec 29, 2021

View reviewed changes

Fixing PhaseII Patatrack failures

5179447

- tests in TrackingRecHit2DCUDA_t - wf 39434.502 due to esconsumes in SiPixelPhase2DigiToClusterCUDA - including pixelTopology constants

AdrianoDee force-pushed the fix_phase2_patatrack branch from 4184826 to 5179447 Compare December 30, 2021 12:06

cmsbuild added code-checks-pending tests-pending and removed tests-approved code-checks-approved labels Dec 30, 2021

cmsbuild removed the code-checks-pending label Dec 30, 2021

cmsbuild added tests-started and removed tests-pending labels Dec 30, 2021

cmsbuild added tests-approved and removed tests-started labels Dec 30, 2021

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Dec 30, 2021

cmsbuild added the urgent label Jan 10, 2022

cmsbuild added fully-signed heterogeneous-approved and removed pending-signatures heterogeneous-pending labels Jan 10, 2022

cmsbuild added orp-approved and removed orp-pending labels Jan 10, 2022

cmsbuild merged commit 3eb7dae into cms-sw:master Jan 10, 2022

This was referenced Jan 11, 2022

Update Geant4 to 10.7ref09 cms-sw/cmsdist#7436

Merged

Updated boost to 1.78 cms-sw/cmsdist#7529

Merged

This was referenced Jan 11, 2022

Unit test failure in TrackingRecHit2DCUDA_t #36605

Closed

Attempt to get ES data using an invalid token in SiPixelPhase2DigiToClusterCUDA #36604

Closed

cmsbuild mentioned this pull request Jan 12, 2022

for external PR tests, make sure to include latest cmssw merges cms-sw/cms-bot#1686

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixing Phase-II Patatrack Failures #36607

Fixing Phase-II Patatrack Failures #36607

AdrianoDee commented Dec 28, 2021

AdrianoDee commented Dec 28, 2021

cmsbuild commented Dec 28, 2021

cmsbuild commented Dec 28, 2021

AdrianoDee commented Dec 28, 2021

AdrianoDee commented Dec 28, 2021

AdrianoDee commented Dec 28, 2021

cmsbuild commented Dec 28, 2021

slava77 Dec 29, 2021

cmsbuild commented Dec 30, 2021

cmsbuild commented Dec 30, 2021

AdrianoDee commented Dec 30, 2021

cmsbuild commented Dec 30, 2021

slava77 commented Dec 30, 2021

mmusich commented Jan 10, 2022

mmusich commented Jan 10, 2022

fwyzard commented Jan 10, 2022 •

edited

makortel commented Jan 10, 2022

cmsbuild commented Jan 10, 2022

fwyzard commented Jan 10, 2022

perrotta commented Jan 10, 2022

Fixing Phase-II Patatrack Failures #36607

Fixing Phase-II Patatrack Failures #36607

Conversation

AdrianoDee commented Dec 28, 2021

AdrianoDee commented Dec 28, 2021

cmsbuild commented Dec 28, 2021

cmsbuild commented Dec 28, 2021

AdrianoDee commented Dec 28, 2021

AdrianoDee commented Dec 28, 2021

AdrianoDee commented Dec 28, 2021

cmsbuild commented Dec 28, 2021

Comparison Summary

slava77 Dec 29, 2021

Choose a reason for hiding this comment

cmsbuild commented Dec 30, 2021

cmsbuild commented Dec 30, 2021

AdrianoDee commented Dec 30, 2021

cmsbuild commented Dec 30, 2021

Comparison Summary

slava77 commented Dec 30, 2021

mmusich commented Jan 10, 2022

mmusich commented Jan 10, 2022

fwyzard commented Jan 10, 2022 • edited

makortel commented Jan 10, 2022

cmsbuild commented Jan 10, 2022

fwyzard commented Jan 10, 2022

perrotta commented Jan 10, 2022

fwyzard commented Jan 10, 2022 •

edited