turn off MET significance calculation in CaloMETs #3662
Conversation
|
A new Pull Request was created by @TaiSakuma (Tai Sakuma) for CMSSW_7_1_X. turn off MET significance calculation in CaloMETs It involves the following packages: RecoMET/METProducers @nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks. |
| @@ -41,7 +41,7 @@ namespace cms | |||
| std::string alias(iConfig.getParameter<std::string>("alias")); | |||
| produces<reco::CaloMETCollection>().setBranchAlias(alias.c_str()); | |||
|
|
|||
| resolutions_ = new metsig::SignAlgoResolutions(iConfig); | |||
| if (calculateSignificance_) resolutions_ = new metsig::SignAlgoResolutions(iConfig); | |||
There was a problem hiding this comment.
resolutions_ does not seem to be deleted once it is created here
There was a problem hiding this comment.
@anton-a, that is a good point. I updated the PR with TaiSakuma@8f67096.
|
why are the tests not started after the updated PR? |
|
Hi, they are currently on the queue. I had paused them because the IB was broken, so the tests would most probably have failed and showed and unrelated error message. |
|
+1 |
turn off MET significance calculation in CaloMETs
This PR turns off MET significance calculation in CaloMETs
We discussed this change at the RECO meeting on 17-Apr-2014: https://indico.cern.ch/event/313948/contribution/18