Drop type specs for JetMET #36651

NiharSaha · 2022-01-08T20:36:56Z

PR description:

Drop type specs in DQMOffline/JetMET python configuration files.

Central DQM migration campaign for drop type spces following
https://cms-sw.github.io/cms_coding_rules.html#6--packaging-rules-1
and update the safer syntax for existing parameters like: (1) drop type specifications where the original parameter exists. (2) using "clone" instead of "deepcopy" (3) move all parameters inside the clone

PR validation:

runTheMatrix.py -l limited -i all --ibeos

cmsbuild · 2022-01-08T20:44:21Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36651/27676

This PR adds an extra 20KB to repository

cmsbuild · 2022-01-08T20:44:43Z

A new Pull Request was created by @NiharSaha (Nihar Ranjan Saha) for master.

It involves the following packages:

DQMOffline/JetMET (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@rappoccio, @ahinzmann, @mmarionncern, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @schoef, @mariadalfonso, @seemasharmafnal, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

jfernan2 · 2022-01-09T09:50:42Z

DQMOffline/JetMET/python/jetAnalyzer_cfi.py

+    JetCorrections = "dqmAk4PFCHSL1FastL2L3ResidualCorrector",
+    jetsrc = "ak4PFJetsCHS",
+    METCollectionLabel     = "pfMETT1",
+    InputMVAPUIDDiscriminant = "pileupJetIdEvaluatorCHSDQM : fullDiscriminant",


I am not sure about the spaces before and after the :
You'd better remove them

jfernan2 · 2022-01-09T09:51:01Z

DQMOffline/JetMET/python/jetAnalyzer_cfi.py

-jetDQMAnalyzerAkCs4PF=jetDQMAnalyzerAkCs3PF.clone(src = cms.InputTag("akCs4PFJets"),
-						  CScands = cms.InputTag("akCs4PFJets","pfParticlesCs")
+jetDQMAnalyzerAkCs4PF=jetDQMAnalyzerAkCs3PF.clone(src = "akCs4PFJets",
+						  CScands = "akCs4PFJets : pfParticlesCs"


same comment

jfernan2 · 2022-01-09T09:51:35Z

DQMOffline/JetMET/python/jetMETAnalyzer_cfi.py

@@ -1,6 +1,6 @@
 import FWCore.ParameterSet.Config as cms

-from DQMOffline.JetMET.jptDQMConfig_cff import *      # parameters for jpt analyzer
+#from DQMOffline.JetMET.jptDQMConfig_cff import *      # parameters for jpt analyzer


Add a comment saying that this line is commented since the config file does not exist

jfernan2 · 2022-01-09T09:52:07Z

DQMOffline/JetMET/python/jetMETAnalyzer_cfi.py

-     caloMETAnalysis = metDQMParameters.clone(
-         allHist = cms.bool(True)
-     ),
+    # caloMETAnalysis = metDQMParameters.clone(


Add a comment saying these lines are commented since metDQMParameters does not exist

jfernan2 · 2022-01-09T09:53:19Z

DQMOffline/JetMET/python/metDQMConfig_cfi.py

-    JetCorrections = cms.InputTag("dqmAk4PFL1FastL2L3ResidualCorrector"),
+    METType = 'pf',
+    METCollectionLabel     = "pfMet",
+    srcPFlow = 'particleFlow : ',


Just srcPFlow = 'particleFlow',

jfernan2 · 2022-01-09T09:53:43Z

DQMOffline/JetMET/python/metDQMConfig_cfi.py

-    JetCorrections = cms.InputTag("dqmAk4PFCHSL1FastL2L3ResidualCorrector"),
+    METType = 'pf',
+    METCollectionLabel     = "pfMETT1",
+    srcPFlow = 'particleFlow: ',


Just srcPFlow = 'particleFlow',

jfernan2 · 2022-01-09T09:54:11Z

DQMOffline/JetMET/python/metDQMConfig_cfi.py

-    srcPFlow = cms.InputTag('packedPFCandidates', ''),
+    fillMetHighLevel = True,#fills only lumisec plots
+    fillCandidateMaps = False,
+    srcPFlow = 'packedPFCandidates: ',


Just srcPFlow = 'packedPFCandidates',

jfernan2 · 2022-01-09T09:54:44Z

DQMOffline/JetMET/python/pfCandidateDQMConfig_cfi.py

-    CandType=cms.untracked.string('Packed'),
-    PFCandidateLabel = cms.InputTag('packedPFCandidates', ''),
+    CandType = 'Packed',
+    PFCandidateLabel = 'packedPFCandidates: ',


Just PFCandidateLabel = 'packedPFCandidates',

cmsbuild · 2022-01-09T10:57:43Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36651/27686

This PR adds an extra 24KB to repository

cmsbuild · 2022-01-09T10:58:06Z

Pull request #36651 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

cmsbuild · 2022-01-09T11:10:30Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36651/27689

This PR adds an extra 24KB to repository

cmsbuild · 2022-01-09T11:10:55Z

Pull request #36651 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

jfernan2 · 2022-01-09T11:33:48Z

please test

cmsbuild · 2022-01-09T14:28:17Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f7376/21577/summary.html
COMMIT: 37af111
CMSSW: CMSSW_12_3_X_2022-01-08-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36651/21577/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 11 differences found in the comparisons
DQMHistoTests: Total files compared: 43
DQMHistoTests: Total histograms compared: 3461659
DQMHistoTests: Total failures: 16
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3461620
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 42 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 181 log files, 42 edm output root files, 43 DQM output files
TriggerResults: no differences found

jfernan2 · 2022-01-09T19:07:33Z

+1

cmsbuild · 2022-01-09T19:07:56Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-01-09T22:37:26Z

+1

Drop type specs for JetMET

a144167

cmsbuild added this to the CMSSW_12_3_X milestone Jan 8, 2022

cmsbuild added code-checks-pending dqm-pending orp-pending pending-signatures tests-pending labels Jan 8, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 8, 2022

jfernan2 reviewed Jan 9, 2022

View reviewed changes

Update jetAnalyzer_cfi.py

63fc7a1

cmsbuild added code-checks-pending and removed code-checks-approved labels Jan 9, 2022

Update jetAnalyzer_cfi.py

9b84090

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 9, 2022

Update jetMETAnalyzer_cfi.py

498215f

cmsbuild added code-checks-pending and removed code-checks-approved labels Jan 9, 2022

NiharSaha added 2 commits January 9, 2022 16:31

Update metDQMConfig_cfi.py

8c8170c

Update pfCandidateDQMConfig_cfi.py

37af111

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 9, 2022

cmsbuild added tests-started and removed tests-pending labels Jan 9, 2022

cmsbuild added tests-approved and removed tests-started labels Jan 9, 2022

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jan 9, 2022

cmsbuild added orp-approved and removed orp-pending labels Jan 9, 2022

cmsbuild merged commit 3dc1382 into cms-sw:master Jan 9, 2022

This was referenced Jan 10, 2022

Update Geant4 to 10.7ref09 cms-sw/cmsdist#7436

Merged

Updated boost to 1.78 cms-sw/cmsdist#7529

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drop type specs for JetMET #36651

Drop type specs for JetMET #36651

NiharSaha commented Jan 8, 2022

cmsbuild commented Jan 8, 2022

cmsbuild commented Jan 8, 2022

jfernan2 Jan 9, 2022

jfernan2 Jan 9, 2022

jfernan2 Jan 9, 2022

jfernan2 Jan 9, 2022

jfernan2 Jan 9, 2022

jfernan2 Jan 9, 2022

jfernan2 Jan 9, 2022

jfernan2 Jan 9, 2022

cmsbuild commented Jan 9, 2022

cmsbuild commented Jan 9, 2022

cmsbuild commented Jan 9, 2022

cmsbuild commented Jan 9, 2022

jfernan2 commented Jan 9, 2022

cmsbuild commented Jan 9, 2022

jfernan2 commented Jan 9, 2022

cmsbuild commented Jan 9, 2022

perrotta commented Jan 9, 2022

Drop type specs for JetMET #36651

Drop type specs for JetMET #36651

Conversation

NiharSaha commented Jan 8, 2022

PR description:

PR validation:

cmsbuild commented Jan 8, 2022

cmsbuild commented Jan 8, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cmsbuild commented Jan 9, 2022

cmsbuild commented Jan 9, 2022

cmsbuild commented Jan 9, 2022

cmsbuild commented Jan 9, 2022

jfernan2 commented Jan 9, 2022

cmsbuild commented Jan 9, 2022

Comparison Summary

jfernan2 commented Jan 9, 2022

cmsbuild commented Jan 9, 2022

perrotta commented Jan 9, 2022