technical fix for value of L1T's caloParams.jetPUSUsePhiRing

[missirol]

PR description:

Simple fix for a type mismatch of one parameter in the cfi files of L1Trigger/L1TCalorimeter.

This misconfiguration causes unnecessary warnings [*] in an application used by HLT (i.e. ConfDB) outside CMSSW. It would also result in that parameter being misconfigured to "None" in ConfDB, if instances of that ESProducer were to be used in HLT configs, which is currently not the case.

I think ConfDB takes the values from caloParams_2018_v1_0_ECALZS_inconsistent_cfi, which inherits the misconfigured parameter from caloParams_cfi, so fixing only the latter would suffice. On the other hand, the fix is applied also to other cfis, as I saw no disadvantage in doing that.

This PR only contains the minimal fix needed for ConfDB. The removal of type-specifications for parameter values of cloned modules is not applied, and is left to the maintainers of this package (coincidentally, this is being discussed in #36644 (review)).

Merely technical. No changes expected.

FYI: @Martin-Grunewald

[*] UInt32Parameter.setValue NumberFormatException: For input string: "False"

PR validation:

$ python3
>>> import FWCore.ParameterSet.Config as cms
>>> a = cms.uint32(0)
>>> b = cms.uint32(False)
>>> a == b
True
>>> a = cms.uint32(1)
>>> b = cms.uint32(True)
>>> a == b
True

If this PR is a backport, please specify the original PR and why you need to backport that PR:

N/A

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36657/27683

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

• L1Trigger/L1TCalorimeter (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[missirol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a640d/21581/summary.html
COMMIT: 8f68006
CMSSW: CMSSW_12_3_X_2022-01-09-0000/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36657/21581/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 43
• DQMHistoTests: Total histograms compared: 3461659
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3461637
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
• Checked 181 log files, 42 edm output root files, 43 DQM output files
• TriggerResults: no differences found

[cecilecaillol]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1