Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TEST_DIR in a CalibPPS/TimingCalibration unit test #36696

Merged
merged 1 commit into from Jan 13, 2022

Conversation

perrotta
Copy link
Contributor

PR description:

That unit test cannot work because it points to a non existing test dir
Not clear why it does not fail in IBs, but it does in some test PR results, for example #36675

PR validation:

Tested that the unit test runs without error if this fix is implemented, while it fails in the original version as:

===== Test "testDiamondLUTCalibration" ====
----- Begin Fatal Exception 11-Jan-2022 19:10:41 UTC-----------------------
An exception of category 'StdException' occurred while
   [0] Processing the python configuration file named src/CondTools/CTPPS/test/ppsTimingCalibrationLUTWriter_cfg.py
Exception Message:
A std::exception was thrown.
File "src/CondTools/CTPPS/test/ppsTimingCalibrationLUTWriter_cfg.py" could not be opened!
----- End Fatal Exception -------------------------------------------------
LUT writer failed: status 66

---> test testDiamondLUTCalibration had ERRORS
TestTime:1
^^^^ End Test testDiamondLUTCalibration ^^^^

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36696/27766

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @perrotta (Andrea Perrotta) for master.

It involves the following packages:

  • CalibPPS/TimingCalibration (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@fabferro, @mmusich, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9aab3d/21677/summary.html
COMMIT: 2676bc8
CMSSW: CMSSW_12_3_X_2022-01-11-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36696/21677/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9aab3d/21677/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9aab3d/21677/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 43
  • DQMHistoTests: Total histograms compared: 3461659
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3461637
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
  • Checked 181 log files, 42 edm output root files, 43 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

@perrotta , it works for IBs as we checkout full cmssw (to run all tests).

@yuanchao
Copy link
Contributor

+1

  • use full path instead of relative path
  • Jenkins code rule error not part of the PR modification

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor Author

+1

@cmsbuild cmsbuild merged commit 728e0d8 into cms-sw:master Jan 13, 2022
@perrotta perrotta deleted the fixTestDirInUnitTest branch January 13, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants