Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut based discriminator against electron (AgainstElectron2) #3671

Merged
merged 2 commits into from May 9, 2014

Conversation

mbluj
Copy link
Contributor

@mbluj mbluj commented May 5, 2014

This request is to add a new cut-based tau discriminator against electron (PFRecoTauDiscriminationAgainstElectron2) which is expected to be used at HLT. The discriminator will be also a simple (and less performant) alternative for a MVA-based discriminant at offline.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2014

A new Pull Request was created by @mbluj for CMSSW_7_1_X.

Cut based discriminator against electron (AgainstElectron2)

It involves the following packages:

RecoTauTag/RecoTau

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@jpavel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mbluj
Copy link
Contributor Author

mbluj commented May 5, 2014

Hello,

for reference I am linking presentations introducing the discriminant:
https://indico.cern.ch/event/313614/contribution/5/material/slides/1.pdf
https://indico.cern.ch/event/315877/contribution/1/material/slides/0.pdf

Michal

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2014

AntiElectronIDCut2::AntiElectronIDCut2()
{
//Default values for the HLT
TauLeadPFChargedHadrEoP_barrel_min_ = 0.99;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove hardcoded numbers from the code.

@anton-a
Copy link

anton-a commented May 7, 2014

Remove root type floats

@anton-a
Copy link

anton-a commented May 7, 2014

My understanding is that this discriminator is targeting use in HLT. Please make timing tests and compare the performance with the current methods.

@mbluj
Copy link
Contributor Author

mbluj commented May 7, 2014

Hi Anton,

the correction will be introduced to the code, thank you for spotting this.

What concerns comparison with existing methods used at offline you can find it in this plot: http://anayak.web.cern.ch/anayak/TauTrigger/AntiEleStudies/EffVsFakeRate_Comparison.pdf A green point corresponds with working point of the new discriminator which should be compared with red curve for current offline cut-based discriminant. Two things should be noted:

  • new discriminator has only one WP defined - other WPs can be defined too.
  • there is not another against-electron discriminant which can work at HLT, even current offline cut-based one uses mva built in PFCandidate (giving electron-likeness) which is not available at HLT.
    Finally, we will certainty preform timing tests, but it should be noted that tau discriminators are run always at the end of the trigger chain after iterative tracking is run. Therefore, even given tau discriminator is not very fast it does not contribute significantly to total execution time of path in each it is executed as the time is dominated by tracking.

Michal

@anton-a
Copy link

anton-a commented May 7, 2014

Thanks, Michal.
Please make changes to the code as soon as you can so that it can be included in the next pre-release.

@mbluj
Copy link
Contributor Author

mbluj commented May 8, 2014

Hi Anton,

code with requested changes has just pushed to the cut-based-againstElectron2 branch on mbluj/cmssw.

Michal

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2014

Pull request #3671 was updated. @nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2014

@anton-a
Copy link

anton-a commented May 9, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request May 9, 2014
Cut based discriminator against electron (AgainstElectron2)
@davidlange6 davidlange6 merged commit f568aa4 into cms-sw:CMSSW_7_1_X May 9, 2014
jpavel added a commit to jpavel/cmssw that referenced this pull request May 13, 2014
@mbluj mbluj deleted the cut-based-againstElectron2 branch December 3, 2014 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants