New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cut based discriminator against electron (AgainstElectron2) #3671
Cut based discriminator against electron (AgainstElectron2) #3671
Conversation
A new Pull Request was created by @mbluj for CMSSW_7_1_X. Cut based discriminator against electron (AgainstElectron2) It involves the following packages: RecoTauTag/RecoTau @nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks. |
Hello, for reference I am linking presentations introducing the discriminant: Michal |
AntiElectronIDCut2::AntiElectronIDCut2() | ||
{ | ||
//Default values for the HLT | ||
TauLeadPFChargedHadrEoP_barrel_min_ = 0.99; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove hardcoded numbers from the code.
Remove root type floats |
My understanding is that this discriminator is targeting use in HLT. Please make timing tests and compare the performance with the current methods. |
Hi Anton, the correction will be introduced to the code, thank you for spotting this. What concerns comparison with existing methods used at offline you can find it in this plot: http://anayak.web.cern.ch/anayak/TauTrigger/AntiEleStudies/EffVsFakeRate_Comparison.pdf A green point corresponds with working point of the new discriminator which should be compared with red curve for current offline cut-based discriminant. Two things should be noted:
Michal |
Thanks, Michal. |
Hi Anton, code with requested changes has just pushed to the cut-based-againstElectron2 branch on mbluj/cmssw. Michal |
+1 |
Cut based discriminator against electron (AgainstElectron2)
This request is to add a new cut-based tau discriminator against electron (PFRecoTauDiscriminationAgainstElectron2) which is expected to be used at HLT. The discriminator will be also a simple (and less performant) alternative for a MVA-based discriminant at offline.