Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT development for 12_3_X + migration to 12_3_0_pre3 template #36731

Merged
merged 3 commits into from Jan 23, 2022

Conversation

missirol
Copy link
Contributor

@missirol missirol commented Jan 18, 2022

PR description:

Development of HLT menus for CMSSW_12_3_X.

Includes the migration of all HLT configurations to the 12_3_0_pre3 template, and the integration of the following JIRA tickets:

  • CMSHLT-2205: [MUO] GEMs in L2-muon producers
  • CMSHLT-2209: [TAU] new TAU paths for Run-3 startup
  • CMSHLT-2213: [BPH] removal of HLTIterativeTrackingIteration1 sequence from BPH paths
  • CMSHLT-2216: [BTV] update of BTagMu paths

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36731/27829

  • This PR adds an extra 808KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

please test

@missirol
Copy link
Contributor Author

The bot reports an error for relvals/input which looks unrelated to this PR (looks like a file-access issue for 1 wf).

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-78c238/21768/summary.html
COMMIT: b3403d1
CMSSW: CMSSW_12_3_X_2022-01-17-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36731/21768/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 4.764.76_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT/step2_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT.log

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 43
  • DQMHistoTests: Total histograms compared: 3441616
  • DQMHistoTests: Total failures: 3012
  • DQMHistoTests: Total nulls: 47
  • DQMHistoTests: Total successes: 3438535
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -4731.95 KiB( 42 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): -746.899 KiB HLT/TAU
  • DQMHistoSizes: changed ( 11634.0,... ): -35.174 KiB HLT/Objects
  • DQMHistoSizes: changed ( 11634.0,... ): -6.586 KiB HLT/Filters
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 181 log files, 42 edm output root files, 43 DQM output files
  • TriggerResults: found differences in 6 / 42 workflows

@missirol
Copy link
Contributor Author

Modulo the unrelated problem with wf 4.76, tests look okay and the comparisons appear consistent with the changes in the GRun menu.

The tests could be re-launched once the issue with wf 4.76 is solved.

@missirol
Copy link
Contributor Author

missirol commented Jan 19, 2022

+hlt

  • differences in outputs of Run-3 wfs are compatible with changes in the HLT menus;
  • the label tests-rejected is due to one unrelated problem with the inputs of wf 4.76 (if the latter is fixed, the tests could be restarted without resetting this signature; I sign because I do not anticipate changes to this PR).

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@Martin-Grunewald
Copy link
Contributor

please test

@Martin-Grunewald
Copy link
Contributor

please test

@missirol missirol changed the title HLT development for 12_3_X HLT development for 12_3_X + migration to 12_3_0_pre3 template Jan 20, 2022
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36731/27877

@cmsbuild
Copy link
Contributor

Pull request #36731 was updated. @Martin-Grunewald, @missirol can you please check and sign again.

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-78c238/21840/summary.html
COMMIT: 29c1fe7
CMSSW: CMSSW_12_3_X_2022-01-19-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36731/21840/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 4.764.76_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT/step2_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT.log

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 43
  • DQMHistoTests: Total histograms compared: 3441614
  • DQMHistoTests: Total failures: 3024
  • DQMHistoTests: Total nulls: 46
  • DQMHistoTests: Total successes: 3438522
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -4731.954 KiB( 42 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): -746.899 KiB HLT/TAU
  • DQMHistoSizes: changed ( 11634.0,... ): -35.174 KiB HLT/Objects
  • DQMHistoSizes: changed ( 11634.0,... ): -6.586 KiB HLT/Filters
  • Checked 181 log files, 42 edm output root files, 43 DQM output files
  • TriggerResults: found differences in 6 / 42 workflows

@Martin-Grunewald
Copy link
Contributor

+1
Relvals-INPUT failure unrelated to this PR.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jan 23, 2022

merge

@cmsbuild cmsbuild merged commit e1c176a into cms-sw:master Jan 23, 2022
@missirol missirol deleted the HLTdevelopment123X branch January 23, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants