Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support arbitrary path names in the TriggerResultsFilter in HLTPathStatus mode [12.2.x] #36733

Merged
merged 1 commit into from Jan 24, 2022
Merged

Support arbitrary path names in the TriggerResultsFilter in HLTPathStatus mode [12.2.x] #36733

merged 1 commit into from Jan 24, 2022

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jan 18, 2022

PR description:

Support arbitrary path names in the TriggerResultsFilter in HLTPathStatus mode

Other changes:

  • clean up and modernise the module
  • add a new unit test for the HLTPathStatus mode

PR validation:

The new unit tests should run.

Backport status

This PR is a backport to 12.2.x of #36732 .

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 18, 2022

backport #36732

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 18, 2022

please test

@cmsbuild cmsbuild added this to the CMSSW_12_2_X milestone Jan 18, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 18, 2022 •
edited

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_12_2_X.

It involves the following packages:

  • HLTrigger/HLTcore (hlt)
  • HLTrigger/HLTfilters (hlt)

@Martin-Grunewald, @missirol can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-39be61/21769/summary.html
COMMIT: b12fbfa
CMSSW: CMSSW_12_2_X_2022-01-18-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36733/21769/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 4.764.76_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT/step2_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT.log

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3250594
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3250566
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 41 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor

To state the obvious: the error in "RelVals-INPUT" is unrelated to this PR, and is being seen in other PRs today. Nevertheless, I guess it would be best to rerun the tests once the issue is solved.

@fwyzard
Support arbitrary path names in the TriggerResultsFilter in HLTPathSt…
a729d1c 
…atus mode

Other changes:
  - clean up and modernise the module
  - add a new unit test for the HLTPathStatus mode
@fwyzard fwyzard force-pushed the triggerResultsFilter_by_TriggerResults branch from b12fbfa to a729d1c Compare January 18, 2022 22:37
@cmsbuild
Copy link
Contributor

Pull request #36733 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 18, 2022

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-39be61/21791/summary.html
COMMIT: a729d1c
CMSSW: CMSSW_12_2_X_2022-01-18-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36733/21791/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 4.764.76_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT/step2_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT.log

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3250594
  • DQMHistoTests: Total failures: 183
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3250388
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 41 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_12_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 23, 2022

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-39be61/21937/summary.html
COMMIT: a729d1c
CMSSW: CMSSW_12_2_X_2022-01-23-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36733/21937/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 4.764.76_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT/step2_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT.log

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3250594
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3250572
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit d0dc7d9 into cms-sw:CMSSW_12_2_X Jan 24, 2022
@fwyzard fwyzard mentioned this pull request Jan 25, 2022
Merged
@fwyzard fwyzard deleted the triggerResultsFilter_by_TriggerResults branch July 31, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok fully-signed hlt-approved orp-approved tests-rejected
Projects
None yet
Milestone
CMSSW_12_2_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fwyzard @cmsbuild @missirol @perrotta