Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename dqmEnv in ALCARECOPPSDiamondSampicTimingCalibHarvester_cff #36735

Merged
merged 1 commit into from Jan 23, 2022

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jan 18, 2022

PR description:

Trivial renaming of dqmEnv to dqmEnvPPSTimingSampicCalibration.
Otherwise using this configuration file I get python configuration errors:

----- Begin Fatal Exception 18-Jan-2022 15:52:58 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named Gains_CT_step2.py
Exception Message:
 unknown python problem occurred.
ValueError: Trying to override definition of dqmEnv while it is used by the sequence ALCAHARVESTPPSDiamondSampicTimingCalibration
 new object defined in: /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc10/cms/cmssw-patch/CMSSW_12_3_X_2022-01-17-2300/python/DQMServices/Components/DQMEventInfo_cfi.py
 existing object defined in: /tmp/musich/CMSSW_12_3_X_2022-01-17-2300/python/CalibPPS/TimingCalibration/ALCARECOPPSDiamondSampicTimingCalibHarvester_cff.py

At:
  /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc10/cms/cmssw-patch/CMSSW_12_3_X_2022-01-17-2300/python/FWCore/ParameterSet/Config.py(478): __setattr__
  /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc10/cms/cmssw-patch/CMSSW_12_3_X_2022-01-17-2300/python/FWCore/ParameterSet/Config.py(737): extend
  /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc10/cms/cmssw-patch/CMSSW_12_3_X_2022-01-17-2300/python/FWCore/ParameterSet/Config.py(714): load
  Gains_CT_step2.py(53): <module>

----- End Fatal Exception -------------------------------------------------

PR validation:

With this patch the executable above runs.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36735/27835

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • CalibPPS/TimingCalibration (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@fabferro, @mmusich, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@yuanchao
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e27488/21809/summary.html
COMMIT: d1de070
CMSSW: CMSSW_12_3_X_2022-01-19-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36735/21809/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 4.764.76_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT/step2_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT.log

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 43
  • DQMHistoTests: Total histograms compared: 3464860
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3464838
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
  • Checked 181 log files, 42 edm output root files, 43 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Jan 19, 2022

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e27488/21809/summary.html
COMMIT: d1de070
CMSSW: CMSSW_12_3_X_2022-01-19-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36735/21809/install.sh to create a dev area with all the needed externals and cmssw changes.

failure looks unrelated (and seems to afflict many other PRs).

@mmusich
Copy link
Contributor Author

mmusich commented Jan 20, 2022

@cms-sw/alca-l2 given there are no other failures (not counting the known issue with 4.76) could this be signed?

@francescobrivio
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jan 23, 2022

merge

@cmsbuild cmsbuild merged commit e80b1cc into cms-sw:master Jan 23, 2022
@mmusich mmusich deleted the fixCalibPPSdqmEnvName branch January 23, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants