Run3-gex108XA Backport al Geometry related files - xml and code for the corrected Run3 geometry #36740

bsunanda · 2022-01-18T19:19:46Z

PR description:

Backport al Geometry related files - xml and code for the corrected Run3 geometry. These files and corrections to the algorithm (dd4hep version) were committed through a number of PR's. These files match with PR #36654

PR validation:

The runTheMatrix test workflows are not affected. They will be done once the scenarios are modified

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR backports #36338, #36470, #36486, #36551, #36648, #36653, #36663, #36755

…un3 geometry

cmsbuild · 2022-01-18T19:20:13Z

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for CMSSW_12_2_X.

It involves the following packages:

Geometry/ForwardCommonData (geometry)
Geometry/GEMGeometryBuilder (geometry, upgrade)
Geometry/MuonCommonData (geometry)
Geometry/MuonSimData (geometry)
Geometry/RPCGeometryBuilder (geometry)
Geometry/TrackerCommonData (geometry)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@giovanni-mocellin, @vargasa, @JanFSchulte, @watson-ij, @ghugo83, @jshlee, @ptcox, @mmusich, @VinInn, @mtosi, @fabiocos, @slomeo, @venturia this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

bsunanda · 2022-01-18T19:55:13Z

@cmsbuild Please test

cmsbuild · 2022-01-18T22:32:11Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-370e9f/21785/summary.html
COMMIT: 14dae1f
CMSSW: CMSSW_12_2_X_2022-01-18-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36740/21785/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

4.764.76_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT/step2_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT.log

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 42
DQMHistoTests: Total histograms compared: 3250594
DQMHistoTests: Total failures: 5
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3250566
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 41 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 177 log files, 37 edm output root files, 42 DQM output files
TriggerResults: no differences found

bsunanda · 2022-01-18T23:26:25Z

It was a file open error in 4.76

bsunanda · 2022-01-18T23:26:38Z

@cmsbuild Please test

cmsbuild · 2022-01-19T05:51:44Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-370e9f/21794/summary.html
COMMIT: 14dae1f
CMSSW: CMSSW_12_2_X_2022-01-18-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36740/21794/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

4.764.76_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT/step2_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT.log

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 42
DQMHistoTests: Total histograms compared: 3250594
DQMHistoTests: Total failures: 11
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3250560
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 41 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 177 log files, 37 edm output root files, 42 DQM output files
TriggerResults: no differences found

bsunanda · 2022-01-19T12:40:12Z

@perrotta @qliphy On both occasions the failure is in a workflow with missing file. This PR has nothing to do with the failure

cmsbuild · 2022-01-20T13:37:18Z

Pull request #36740 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please check and sign again.

bsunanda · 2022-01-20T16:08:31Z

@cmsbuild Please test

cmsbuild · 2022-01-20T19:12:48Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-370e9f/21854/summary.html
COMMIT: 73cac89
CMSSW: CMSSW_12_2_X_2022-01-20-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36740/21854/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

4.764.76_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT/step2_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT.log

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 42
DQMHistoTests: Total histograms compared: 3250594
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3250572
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
Checked 177 log files, 37 edm output root files, 42 DQM output files
TriggerResults: no differences found

cmsbuild · 2022-01-28T16:19:11Z

Pull request #36740 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please check and sign again.

bsunanda · 2022-01-28T16:19:47Z

@cmsbuild Please test

cmsbuild · 2022-01-28T18:24:03Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-370e9f/22062/summary.html
COMMIT: 0e51ff3
CMSSW: CMSSW_12_2_X_2022-01-28-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36740/22062/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 42
DQMHistoTests: Total histograms compared: 3250594
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3250572
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
Checked 177 log files, 37 edm output root files, 42 DQM output files
TriggerResults: no differences found

perrotta · 2022-01-30T18:28:39Z

This PR now fully backports #36338, #36470, #36486, #36551, #36648, #36653, #36663, #36755, thus reflecting correctly what stated in the PR description

srimanob · 2022-02-01T17:02:37Z

+Upgrade

Needed XML and test config files are backported to 12_2 in this PR. No change is expected from PR test.

cvuosalo · 2022-02-02T21:13:40Z

+1

cmsbuild · 2022-02-02T21:14:02Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-02-07T19:55:35Z

+1

Add xml files and related stuffs needed for the updated Run3 geometry, but does not implement it yet

Backport al Geometry related files - xml and code for the corrected R…

14dae1f

…un3 geometry

cmsbuild added this to the CMSSW_12_2_X milestone Jan 18, 2022

cmsbuild added geometry-pending orp-pending pending-signatures tests-pending upgrade-pending labels Jan 18, 2022

cmsbuild added tests-started and removed tests-pending labels Jan 18, 2022

cmsbuild added tests-rejected and removed tests-started labels Jan 18, 2022

cmsbuild added tests-started and removed tests-rejected labels Jan 18, 2022

cmsbuild added tests-rejected and removed tests-started labels Jan 19, 2022

Correct rpcf as done in master

73cac89

cmsbuild added tests-pending and removed tests-rejected labels Jan 20, 2022

cmsbuild added tests-started and removed tests-pending labels Jan 20, 2022

cmsbuild added geometry-pending pending-signatures tests-pending upgrade-pending and removed geometry-approved fully-signed tests-rejected upgrade-approved labels Jan 28, 2022

cmsbuild added tests-started and removed tests-pending labels Jan 28, 2022

cmsbuild added tests-approved and removed tests-started labels Jan 28, 2022

cmsbuild added upgrade-approved and removed upgrade-pending labels Feb 1, 2022

cmsbuild added fully-signed geometry-approved and removed geometry-pending pending-signatures labels Feb 2, 2022

perrotta mentioned this pull request Feb 3, 2022

[DDD] Fix building of DDD GEM reco geometry DB payload, backport of #36869 #36870

Merged

cmsbuild added orp-approved and removed orp-pending labels Feb 7, 2022

cmsbuild merged commit 70f25db into cms-sw:CMSSW_12_2_X Feb 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run3-gex108XA Backport al Geometry related files - xml and code for the corrected Run3 geometry #36740

Run3-gex108XA Backport al Geometry related files - xml and code for the corrected Run3 geometry #36740

bsunanda commented Jan 18, 2022 •

edited

cmsbuild commented Jan 18, 2022

bsunanda commented Jan 18, 2022

cmsbuild commented Jan 18, 2022

bsunanda commented Jan 18, 2022

bsunanda commented Jan 18, 2022

cmsbuild commented Jan 19, 2022

bsunanda commented Jan 19, 2022

cmsbuild commented Jan 20, 2022

bsunanda commented Jan 20, 2022

cmsbuild commented Jan 20, 2022

cmsbuild commented Jan 28, 2022

bsunanda commented Jan 28, 2022

cmsbuild commented Jan 28, 2022

perrotta commented Jan 30, 2022

srimanob commented Feb 1, 2022

cvuosalo commented Feb 2, 2022

cmsbuild commented Feb 2, 2022

perrotta commented Feb 7, 2022

Run3-gex108XA Backport al Geometry related files - xml and code for the corrected Run3 geometry #36740

Run3-gex108XA Backport al Geometry related files - xml and code for the corrected Run3 geometry #36740

Conversation

bsunanda commented Jan 18, 2022 • edited

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jan 18, 2022

bsunanda commented Jan 18, 2022

cmsbuild commented Jan 18, 2022

RelVals-INPUT

Comparison Summary

bsunanda commented Jan 18, 2022

bsunanda commented Jan 18, 2022

cmsbuild commented Jan 19, 2022

RelVals-INPUT

Comparison Summary

bsunanda commented Jan 19, 2022

cmsbuild commented Jan 20, 2022

bsunanda commented Jan 20, 2022

cmsbuild commented Jan 20, 2022

RelVals-INPUT

Comparison Summary

cmsbuild commented Jan 28, 2022

bsunanda commented Jan 28, 2022

cmsbuild commented Jan 28, 2022

Comparison Summary

perrotta commented Jan 30, 2022

srimanob commented Feb 1, 2022

cvuosalo commented Feb 2, 2022

cmsbuild commented Feb 2, 2022

perrotta commented Feb 7, 2022

bsunanda commented Jan 18, 2022 •

edited