ECAL Phase 2 Development WF 28234.61 fix

[thomreis]

PR description:

The Phase 2 ECAL development WF 28234.61 currently fails at the reco step. This PR fixes this by removing unnecessary non-ECAL development related tasks and making sure that all inputs for step3 and step4 are available.
It also runs the Phase 2 weights based uncalibrated RecHits producer introduced in #34505, the first ECAL Phase 2 reco algorithm. Small changes to the EcalRecHitProducer were necessary to allow it to run only on barrel uncalibrated RecHits as it will be for Phase 2.

PR validation:

Passes the standard limited matrix tests and also 28234.61.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36748/27855

• This PR adds an extra 60KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/EventContent/python/EventContent_cff.py modified in PR(s): Remove Event Interpretation (EI) from relval steps #36465
  • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Phase 2 HLT menu targetting 7.5×10³⁴ cm⁻²s⁻¹ #35342, Phase2 tracker: add T30 (geometry with more realistic TFPX) #36660, Add run3 tracking low pu era #33532, Remove Event Interpretation (EI) from relval steps #36465

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36748/27855/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36748/27855/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36748/27857

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/EventContent/python/EventContent_cff.py modified in PR(s): Remove Event Interpretation (EI) from relval steps #36465
  • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Phase 2 HLT menu targetting 7.5×10³⁴ cm⁻²s⁻¹ #35342, Phase2 tracker: add T30 (geometry with more realistic TFPX) #36660, Add run3 tracking low pu era #33532, Remove Event Interpretation (EI) from relval steps #36465

[cmsbuild]

A new Pull Request was created by @thomreis (Thomas Reis) for master.

It involves the following packages:

• Configuration/EventContent (operations)
• Configuration/PyReleaseValidation (pdmv, upgrade)
• Configuration/StandardSequences (operations)
• DQMOffline/Configuration (dqm)
• RecoLocalCalo/Configuration (reconstruction)
• RecoLocalCalo/EcalRecProducers (reconstruction)
• Validation/Configuration (dqm, simulation)

@bbilin, @wajidalikhan, @perrotta, @civanch, @ahmad3213, @cmsbuild, @pmandrik, @emanueleusai, @mdhildreth, @AdrianoDee, @jfernan2, @kskovpen, @slava77, @jpata, @qliphy, @fabiocos, @pbo0, @jordan-martins, @clacaputo, @srimanob, @davidlange6, @rvenditti can you please review it and eventually sign? Thanks.
@felicepantaleo, @kpedro88, @argiro, @Martin-Grunewald, @thomreis, @threus, @mmusich, @slomeo, @missirol, @makortel, @JanFSchulte, @dgulhan, @apsallid, @simonepigazzini, @rociovilar, @GiacomoSguazzoni, @rovere, @VinInn, @ebrondol, @mtosi, @fabiocos, @rchatter, @lecriste this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d7d2a8/21812/summary.html
COMMIT: fdd8816
CMSSW: CMSSW_12_3_X_2022-01-19-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36748/21812/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 4.764.76_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT/step2_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT.log

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 43
• DQMHistoTests: Total histograms compared: 3464860
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3464832
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 42 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 181 log files, 42 edm output root files, 43 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[AdrianoDee]

+Upgrade
Fix to 28234.61 as stared. Tests (+ 28234.61) run.

[kskovpen]

+1

[jpata]

+reconstruction

• on top of ECAL Phase 2 Development WF 28234.61 fix #36748 (comment), fix duplicated type specs (thx @perrotta for pointing it out)

[civanch]

+1

[perrotta]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.