Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPS renaming alca reco producers - backport of PR#36702 to 12_2_X #36784

Merged
merged 6 commits into from Jan 24, 2022

Conversation

grzanka
Copy link
Contributor

@grzanka grzanka commented Jan 23, 2022

PR description:

This is a backport of #36702 to 12_2_X

It is related to cms-AlCaDB/AlCaTools#53

The changes are necessary for T0 replay with PPS. The suggestions for renaming appeared in the discussion of #36273
It is following #36698

PR validation:

Tested with:

runTheMatrix.py -l 1041 --ibeos
runTheMatrix.py -l 1042 --ibeos

grzanka and others added 6 commits January 23, 2022 09:46
PromptCalibProdPPS -> PromptCalibProdPPSTimingCalib
Via #58

* renaming according to guidelines for Tier0 replay

* pps alignment renaming - part 2

* pps alignment renaming - part 3 (paths)

* Updated the PPS alignment AlCa file names.

PPSAlignment -> PromptCalibProdPPSAlignment

Co-authored-by: Mateusz <mateuszkocot99@gmail.com>
Conflicts:
	Configuration/AlCa/python/autoPCL.py
	Configuration/EventContent/python/AlCaRecoOutput_cff.py
	Configuration/StandardSequences/python/AlCaRecoStreams_cff.py
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 23, 2022

A new Pull Request was created by @grzanka (Leszek Grzanka) for CMSSW_12_2_X.

It involves the following packages:

  • CalibPPS/AlignmentGlobal (alca)
  • CalibPPS/TimingCalibration (alca)
  • Configuration/AlCa (alca)
  • Configuration/EventContent (operations)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • Configuration/StandardSequences (operations)

@perrotta, @malbouis, @yuanchao, @jordan-martins, @bbilin, @wajidalikhan, @tvami, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @qliphy, @francescobrivio, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @felicepantaleo, @fabferro, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @ebrondol, @tocheng, @lecriste, @mmusich, @slomeo, @mtosi, @dgulhan, @kpedro88 this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor

test parameters:

  • workflows = 1041,1042

@srimanob
Copy link
Contributor

@cmsbuild please test

@tvami
Copy link
Contributor

tvami commented Jan 23, 2022

backport of #36702

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-77c91d/21934/summary.html
COMMIT: 066c302
CMSSW: CMSSW_12_2_X_2022-01-23-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36784/21934/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-77c91d/21934/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-77c91d/21934/git-merge-result

RelVals-INPUT

  • 4.764.76_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT/step2_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT.log

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /pool/condor/dir_83255/jenkins/workspace/compare-root-files-short-matrix/data/PR-77c91d/1041.0_RunExpressPhy2017F+RunExpressPhy2017F+TIER0EXPPPSCAL+ALCASPLITPPSCAL+ALCAHARVDPPSCAL
  • /pool/condor/dir_83255/jenkins/workspace/compare-root-files-short-matrix/data/PR-77c91d/1042.0_RunExpressPhy2017F+RunExpressPhy2017F+TIER0EXPPPSCALALIG+ALCASPLITPPSALIG+ALCAHARVDPPSALIG

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3250594
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3250572
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

+Upgrade

Backport PR. PR test runs fine, the additional workflows with the change run fine.

@tvami
Copy link
Contributor

tvami commented Jan 23, 2022

+alca

@tvami
Copy link
Contributor

tvami commented Jan 23, 2022

Hi @kskovpen you signed the original PR for this, please consider signing the backport as well, thanks!

@kskovpen
Copy link
Contributor

+1

@tvami
Copy link
Contributor

tvami commented Jan 23, 2022

Hi @perrotta @qliphy this is essentially fully signed. I guess we should wait a day to see how the IB goes with the master PR and merge this. We'll also request to cut a 12_2_0 so these PPS workflows can be tested. We can discuss the details on Tuesday's ORP

@qliphy
Copy link
Contributor

qliphy commented Jan 24, 2022

Hi @perrotta @qliphy this is essentially fully signed. I guess we should wait a day to see how the IB goes with the master PR and merge this. We'll also request to cut a 12_2_0 so these PPS workflows can be tested. We can discuss the details on Tuesday's ORP

@tvami This week's ORP will be cancelled due to ongoing CMSWeek. However, we can merge this PR and build next 12_2_X this week if it is really urgently needed.

@qliphy
Copy link
Contributor

qliphy commented Jan 24, 2022

merge
Master PR IB test looks good

@cmsbuild cmsbuild merged commit d0720a6 into cms-sw:CMSSW_12_2_X Jan 24, 2022
@tvami
Copy link
Contributor

tvami commented Jan 24, 2022

build next 12_2_X this week if it is really urgently needed.

Yes that would be great! But we can wait for the geometry backports before cutting a new 12_2_X release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants