Run3-gex115 Tune CaloGeometryBuilder for changing configuration

[bsunanda]

PR description:

Tune CaloGeometryBuilder for changing configuration

PR validation:

Use runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36814/27970

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Geometry/CaloEventSetup (geometry)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth can you please review it and eventually sign? Thanks.
@simonepigazzini, @fabiocos, @thomreis this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc9967/22030/summary.html
COMMIT: af5f501
CMSSW: CMSSW_12_3_X_2022-01-26-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36814/22030/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 1 differences found in the comparisons
• DQMHistoTests: Total files compared: 43
• DQMHistoTests: Total histograms compared: 3449324
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3449302
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
• Checked 181 log files, 42 edm output root files, 43 DQM output files
• TriggerResults: no differences found

[cvuosalo]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[cvuosalo]

This PR fixes part of issue #36806.

[tvami]

Hi @bsunanda please submit a backport to 12_2_X as well, thanks!

[srimanob]

I'm not sure I understand the change related to Phase-2. Could you please clarify?

The CaloGeometryPhaseII_cff.py calls CaloGeometryBuilderPhaseII_cfi where the change is applied. However, this PR also introduce Phase-2 modifier which seems to do the same. But who will call this? Or should we change the way to call, e.g. call CaloGeometryBuilder_cfi.py directly, so that we can remove CaloGeometryPhaseII_cff.py ?

[srimanob]

I assume no change is expected for Run-3 as CASTOR is not there.

What is the effect of the change on Phase-2 when HGCAL is added to the configuration?

[bsunanda]

Castor is not in Run3 nor in PhaseII. This PR protects against accessing geometry from DB. Phase2 geometries at this moment do not use any of CaloGeometryBuilder..._cfi.py. They are corrected in view of using them in the future.

[perrotta]

@bsunanda let me check if I understood correctly your answer to the question of @srimanob : are you meaning that the configurations collected in CaloGeometryPhaseII_cff.py are at the moment just listed there, and kept sincronized, because at some point that file will be linked directly for Phase2, instead of using the modifiers?

[tvami]

type bugfix

• w/o this when removing Castor Run-3 tags, the code fails because it looks for the non-existing Run-3 Castor geometry

[tvami]

@bsunanda could you maybe include in the title of the PR that what it does is to remove Castor from Run3? Thanks

[perrotta]

+1

• Following discussion at today's ORP