Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-gex115A Tune CaloGeometryBuilder for changing CMS configuration - backport #36814 #36816

Merged
merged 1 commit into from Feb 1, 2022

Conversation

bsunanda
Copy link
Contributor

PR description:

Tune CaloGeometryBuilder for changing CMS configuration - backport #36814

PR validation:

The original PR is tested using the runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport PR #36814

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 27, 2022

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for CMSSW_12_2_X.

It involves the following packages:

  • Geometry/CaloEventSetup (geometry)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@simonepigazzini, @fabiocos, @thomreis this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-306867/22034/summary.html
COMMIT: ea133ae
CMSSW: CMSSW_12_2_X_2022-01-26-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36816/22034/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3250594
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3250566
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@cvuosalo
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@tvami
Copy link
Contributor

tvami commented Feb 1, 2022

urgent

  • we need this for DD4HEP data tests

@tvami
Copy link
Contributor

tvami commented Feb 1, 2022

type bugfix

@perrotta
Copy link
Contributor

perrotta commented Feb 1, 2022

+1

  • Following discussion at today's ORP

@cmsbuild cmsbuild merged commit 65d1df2 into cms-sw:CMSSW_12_2_X Feb 1, 2022
@tvami
Copy link
Contributor

tvami commented Feb 1, 2022

@bsunanda can you please change the title so it says that it removes Castor from Run3? Also please include [12_2_X] in the title so it's obvious that the backport is for that release

@tvami
Copy link
Contributor

tvami commented Feb 1, 2022

@perrotta I think you merged the backport first and not the master PR first

@tvami
Copy link
Contributor

tvami commented Feb 1, 2022

backport of #36814

@perrotta
Copy link
Contributor

perrotta commented Feb 1, 2022

@perrotta I think you merged the backport first and not the master PR first

Yes, you are right, sorry for that... I did not suppose that the "urgent" flag was for the backport PR, as all PRs to be backported are kind of urgent...
Ok, since it is already merged, let have the two (master and 12_2) merged at the same time: in case of issues, not expected anyhow, we will revert this one.

@tvami
Copy link
Contributor

tvami commented Feb 1, 2022

I did not suppose that the "urgent" flag was for the backport PR,

Sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants