Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecation warnings from FastSimulation/Track* #36825

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jan 28, 2022

PR description:

Part of the migration in #31061.
Went systematically through all of the CMSDEPRECATED_X warnings in the FastSimulation/Track* subsystem from CMSSW_12_3_CMSDEPRECATED_X_2022-01-21-2300 and removed all deprecated EventSetup API calls.

PR validation:

cmssw compiles

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36825/27987

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • FastSimulation/TrackerSetup (fastsim)
  • FastSimulation/Tracking (fastsim)

@ssekmen, @lveldere, @civanch, @mdhildreth, @cmsbuild, @sbein can you please review it and eventually sign? Thanks.
@matt-komm this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jan 28, 2022

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-63edca/22057/summary.html
COMMIT: 4cbae13
CMSSW: CMSSW_12_3_X_2022-01-27-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36825/22057/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 43
  • DQMHistoTests: Total histograms compared: 3449612
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3449578
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
  • Checked 181 log files, 42 edm output root files, 43 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Feb 1, 2022

@cms-sw/fastsim-l2 any comment on this PR?

@civanch
Copy link
Contributor

civanch commented Feb 4, 2022

@sbein , please, comment

@mmusich
Copy link
Contributor Author

mmusich commented Feb 10, 2022

@cms-sw/orp-l2 this simple PR has stayed idle with no sign of review for 13 days now.
Please consider skipping the @cms-sw/fastsim-l2 signature.
Thank you.

@mmusich mmusich force-pushed the getRidDeprecationWarningsFastSimulationTrack branch from 2ff6dec to bdc9f37 Compare February 10, 2022 15:01
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36825/28254

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

Pull request #36825 was updated. @ssekmen, @lveldere, @civanch, @mdhildreth, @cmsbuild, @sbein can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Feb 10, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-63edca/22337/summary.html
COMMIT: bdc9f37
CMSSW: CMSSW_12_3_X_2022-02-10-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36825/22337/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3764420
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3764396
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 193 log files, 42 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@sbein
Copy link
Contributor

sbein commented Feb 10, 2022

i will check in the next hour

@sbein
Copy link
Contributor

sbein commented Feb 10, 2022

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a4ea9df into cms-sw:master Feb 10, 2022
@mmusich mmusich deleted the getRidDeprecationWarningsFastSimulationTrack branch February 10, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants