Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ge2/1 demonstrator in validation #36835

Merged
merged 7 commits into from
Feb 2, 2022
Merged

fix ge2/1 demonstrator in validation #36835

merged 7 commits into from
Feb 2, 2022

Commits on Jan 30, 2022

  1. fix ge2/1 demonstrator in validation

    @watson-ij
    watson-ij committed Jan 30, 2022
    Configuration menu
    Copy the full SHA
    4edb955 View commit details
    Browse the repository at this point in the history

  2. format

    @watson-ij
    watson-ij committed Jan 30, 2022
    Configuration menu
    Copy the full SHA
    9860b88 View commit details
    Browse the repository at this point in the history

  3. fix warning

    @watson-ij
    watson-ij committed Jan 30, 2022
    Configuration menu
    Copy the full SHA
    4f55f8a View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2022

  1. Process demonstrator geometry also for database geometry

    @watson-ij
    watson-ij committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    f7a68d3 View commit details
    Browse the repository at this point in the history

  2. Remove workaround for demonstrator geometry in conddb builder

    @watson-ij
    watson-ij committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    40dbfab View commit details
    Browse the repository at this point in the history

  3. Update Geometry/GEMGeometryBuilder/src/GEMGeometryParsFromDD.cc 

    Stop iterating once we know we are not in the demonstrator geometry

Co-authored-by: Carl Vuosalo <cvuosalo@users.noreply.github.com>
    @watson-ij @cvuosalo
    watson-ij and cvuosalo committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    d9d2774 View commit details
    Browse the repository at this point in the history

  4. Add Carl's suggestions

    @watson-ij
    watson-ij committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    66f0620 View commit details
    Browse the repository at this point in the history