Update of some L1T producers for L1TNtuples (legacy modules), of the L1TExtCondProducer, and of the L1MenuViewer #36839

elfontan · 2022-01-30T22:32:54Z

PR description:

This PR includes some updates related to the L1 trigger emulation:

Updates of some producers used to produce L1TNtuples that were causing warnings because they were legacy modules:
L1UpgradeTfMuonTreeProducer, L1UpgradeTreeProducer, L1HOTreeProducer, L1EventTreeProducer.
Update of the L1TExtCondProducer, where a problem related to the usage of the hltGetConfiguration command for MC (uGT only, not FullMC) occured. The issue is related to the configuration file SimL1EmulatorRepack_uGT_cff, where simGtExtFakeStage2Digis.tcdsRecordLabel is modified both for data and MC. However, the label InputTag("unpackTcds","tcdsRecord") for MC implies some checks in the L1ExtCondProducer that are failing. After some investigation, it seems that this tcdsRecordLabel and related input tag should be used as InputTag("unpackTcds","tcdsRecord") only for data. The implemented fix allows to consider all different scenarios in a proper way: FullMC (InputTag empty --> no checks), Full (InputTag ("unpackTcds","tcdsRecord") and real data), uGT data (InputTag ("unpackTcds","tcdsRecord") and real data), uGT MC (InputTag ("unpackTcds","tcdsRecord") BUT not real data --> checks skipped).
Fix of the L1MenuViewer to avoid an exception MustUseESGetToken.
Update of the script use to produce test vectors including example files produced with CMSSW_12X and a small fix needed for the migration to Python3.

PR validation:

Basic tests performed successfully starting from CMSSW_12_3_X_2022-01-26-1100.
From CMSSW_12_3_X_2022-01-26-1100/src:

scram b distclean
git cms-checkdeps -a -A
scram b -j 8
scram b runtests
scram build code-checks
scram build code-format
runTheMatrix.py -l limited -i all --ibeos

…cer.cc to run the emulation on MC correctly with the uGT option

cmsbuild · 2022-01-30T22:41:12Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36839/28027

This PR adds an extra 28KB to repository

cmsbuild · 2022-01-30T22:41:32Z

A new Pull Request was created by @elfontan (Elisa Fontanesi) for master.

It involves the following packages:

L1Trigger/L1TGlobal (l1)
L1Trigger/L1TNtuples (l1)
L1TriggerConfig/Utilities (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @dinyar, @kreczko, @thomreis this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

missirol · 2022-01-31T07:53:32Z

L1Trigger/L1TGlobal/plugins/L1TExtCondProducer.cc

@@ -137,7 +137,7 @@ void L1TExtCondProducer::produce(Event& iEvent, const EventSetup& iSetup) {
  }

  bool TriggerRulePrefireVetoBit(false);
-  if (makeTriggerRulePrefireVetoBit_) {
+  if (iEvent.isRealData() && makeTriggerRulePrefireVetoBit_) {
    // code taken from Nick Smith's EventFilter/L1TRawToDigi/plugins/TriggerRulePrefireVetoFilter.cc



@elfontan , thanks for following up on these fixes. Imho, the following change should also be included in L1TExtCondProducer.cc to avoid the seg-fault discussed in #36786 (comment) , throwing an exception instead:

// should be 16 according to TCDSRecord.h, we only care about the last 4 if (eventHistory.size() < 4) { - edm::LogError("L1TExtCondProducer") << "Unexpectedly small L1A history from TCDSRecord"; + throw cms::Exception("L1TExtCondProducer") << "Unexpectedly small L1A history from TCDSRecord: (size = " << eventHistory.size() << " < 4)"; }

The reason is that LogError does not stop the routine, but after that the code assumes that the vector has at least size==4 , and this is what caused the seg-fault.

elfontan · 2022-01-31T09:02:32Z

Hi @missirol,
thank you for looking into this!
Sure, I can change that line, too. Should I then coherently change all the edm::LogError to throw cms::Exception, in your opinion? Do you see any problem with this?

Cheers,
--Elisa

missirol · 2022-01-31T09:27:29Z

Should I then coherently change all the edm::LogError to throw cms::Exception, in your opinion?

Well, this would be a question for experts of this plugin. From reading the code, I would say it's not necessary to change the other LogError calls: they signal that there is something wrong/unexpected going on, but the plugin won't crash as a result (unlike for the first LogError call, which should change to an Exception); for these other LogError calls, the worst that can happen is that TriggerRulePrefireVetoBit remains false.

…avoid segmentation fault

cmsbuild · 2022-01-31T10:22:23Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36839/28034

This PR adds an extra 28KB to repository

cmsbuild · 2022-01-31T10:22:47Z

Pull request #36839 was updated. @epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please check and sign again.

cecilecaillol · 2022-01-31T11:01:26Z

please test

cmsbuild · 2022-01-31T13:41:01Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-63ed00/22098/summary.html
COMMIT: 0f7b567
CMSSW: CMSSW_12_3_X_2022-01-30-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36839/22098/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS StaticAnalyzer warnings: There are 1 inherits from legacy modules warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-63ed00/22098/llvm-analysis/legacy-mod-sa.txt for details.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 1 differences found in the comparisons
DQMHistoTests: Total files compared: 43
DQMHistoTests: Total histograms compared: 3449612
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3449590
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
Checked 181 log files, 42 edm output root files, 43 DQM output files
TriggerResults: no differences found

cecilecaillol · 2022-01-31T13:44:31Z

+l1

cmsbuild · 2022-02-01T19:06:28Z

Pull request #36839 was updated. @epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please check and sign again.

perrotta · 2022-02-01T21:37:47Z

@elfontan if you want to make const l1GtMenuToken_ you must initialize it in the class initializer list

…izer

cmsbuild · 2022-02-01T23:32:34Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36839/28100

This PR adds an extra 32KB to repository

cmsbuild · 2022-02-01T23:33:01Z

Pull request #36839 was updated. @epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please check and sign again.

cecilecaillol · 2022-02-02T06:28:52Z

please test

cmsbuild · 2022-02-02T10:37:20Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-63ed00/22140/summary.html
COMMIT: 9699119
CMSSW: CMSSW_12_3_X_2022-02-01-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36839/22140/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 7 differences found in the comparisons
DQMHistoTests: Total files compared: 43
DQMHistoTests: Total histograms compared: 3449612
DQMHistoTests: Total failures: 12
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3449578
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
Checked 181 log files, 42 edm output root files, 43 DQM output files
TriggerResults: no differences found

cecilecaillol · 2022-02-02T17:06:24Z

+l1

cmsbuild · 2022-02-02T17:06:49Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-02-02T18:11:30Z

+1

elfontan added 3 commits January 26, 2022 20:05

Fixed tools to generate test vectors

7a22eb1

Token switched to const and fix of the L1EventTreeProducer destructor

a097b0a

Code-checks in the L1TNtuples producers and update of L1TExtCondProdu…

bb42398

…cer.cc to run the emulation on MC correctly with the uGT option

cmsbuild added this to the CMSSW_12_3_X milestone Jan 30, 2022

cmsbuild added code-checks-pending l1-pending orp-pending pending-signatures tests-pending labels Jan 30, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 30, 2022

missirol reviewed Jan 31, 2022

View reviewed changes

LogError related to the tcdsRecord changed to throw an exception and …

0f7b567

…avoid segmentation fault

cmsbuild added code-checks-pending and removed code-checks-approved labels Jan 31, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 31, 2022

cmsbuild added tests-started and removed tests-pending labels Jan 31, 2022

cmsbuild added tests-approved and removed tests-started labels Jan 31, 2022

l1GtMenuToken_ declared as const and initialized in the class initial…

9699119

…izer

cmsbuild added code-checks-pending and removed code-checks-approved labels Feb 1, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 1, 2022

cmsbuild added tests-started and removed tests-pending labels Feb 2, 2022

cmsbuild added tests-approved and removed tests-started labels Feb 2, 2022

cmsbuild added fully-signed l1-approved and removed l1-pending pending-signatures labels Feb 2, 2022

cmsbuild added orp-approved and removed orp-pending labels Feb 2, 2022

cmsbuild merged commit d732e13 into cms-sw:master Feb 2, 2022

cmsbuild mentioned this pull request Feb 2, 2022

mkFit external integration #36546

Merged

elfontan mentioned this pull request Feb 3, 2022

Fix for l1Event in the L1EventTreeProducer #36875

Merged

perrotta mentioned this pull request Feb 4, 2022

Exception when calling the method EventSetup module RPCConeBuilder #36786

Closed

epalencia mentioned this pull request Feb 4, 2022

Update of some L1T producers... (backport from Master) cms-l1t-offline/cmssw#978

Merged

elfontan deleted the EF_L1Tfixes branch February 22, 2022 15:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update of some L1T producers for L1TNtuples (legacy modules), of the L1TExtCondProducer, and of the L1MenuViewer #36839

Update of some L1T producers for L1TNtuples (legacy modules), of the L1TExtCondProducer, and of the L1MenuViewer #36839

elfontan commented Jan 30, 2022 •

edited

cmsbuild commented Jan 30, 2022

cmsbuild commented Jan 30, 2022

missirol Jan 31, 2022

elfontan commented Jan 31, 2022

missirol commented Jan 31, 2022 •

edited

cmsbuild commented Jan 31, 2022

cmsbuild commented Jan 31, 2022

cecilecaillol commented Jan 31, 2022

cmsbuild commented Jan 31, 2022

cecilecaillol commented Jan 31, 2022

cmsbuild commented Feb 1, 2022

perrotta commented Feb 1, 2022

cmsbuild commented Feb 1, 2022

cmsbuild commented Feb 1, 2022

cecilecaillol commented Feb 2, 2022

cmsbuild commented Feb 2, 2022

cecilecaillol commented Feb 2, 2022

cmsbuild commented Feb 2, 2022

perrotta commented Feb 2, 2022

Update of some L1T producers for L1TNtuples (legacy modules), of the L1TExtCondProducer, and of the L1MenuViewer #36839

Update of some L1T producers for L1TNtuples (legacy modules), of the L1TExtCondProducer, and of the L1MenuViewer #36839

Conversation

elfontan commented Jan 30, 2022 • edited

PR description:

PR validation:

cmsbuild commented Jan 30, 2022

cmsbuild commented Jan 30, 2022

missirol Jan 31, 2022

Choose a reason for hiding this comment

elfontan commented Jan 31, 2022

missirol commented Jan 31, 2022 • edited

cmsbuild commented Jan 31, 2022

cmsbuild commented Jan 31, 2022

cecilecaillol commented Jan 31, 2022

cmsbuild commented Jan 31, 2022

Comparison Summary

cecilecaillol commented Jan 31, 2022

cmsbuild commented Feb 1, 2022

perrotta commented Feb 1, 2022

cmsbuild commented Feb 1, 2022

cmsbuild commented Feb 1, 2022

cecilecaillol commented Feb 2, 2022

cmsbuild commented Feb 2, 2022

Comparison Summary

cecilecaillol commented Feb 2, 2022

cmsbuild commented Feb 2, 2022

perrotta commented Feb 2, 2022

elfontan commented Jan 30, 2022 •

edited

missirol commented Jan 31, 2022 •

edited