fix bug in NANOAOD Pileup_nTrueInt variable (int instead of float)

[kirschen]

PR description:

Follow-up of thread "Pileup_nTrueInt in nanoAOD v9"
https://hypernews.cern.ch/HyperNews/CMS/get/physTools/3811/1/1/1.html

PR validation:

Ran
runTheMatrix.py -l 1325.81 --sites ""
and in a second step adapted the input to a sample with flatPU distribution (runTheMatrix sample has integer true PU 35). Output is as expected:

root [6] Events->Scan("Pileup_nTrueInt")
************************
*    Row   * Pileup_nT *
************************
*        0 * 12.430791 *
*        1 * 9.1569194 *
*        2 * 18.460222 *
*        3 * 26.073337 *
*        4 * 10.425618 *
*        5 * 8.3619899 *

Whereas previous nanoAOD had integer values for Pileup_nTrueInt, e.g. (from the same dataset as used for the test above)

Attaching file root://xrootd-cms.infn.it//store/mc/RunIISummer19UL16NanoAODv2/QCD_Pt-15to7000_TuneCP5_Flat2018_13TeV_pythia8/NANOAODSIM/FlatPU0to70_106X_mcRun2_asymptotic_v15-v1/270000/05FEFA95-6CDF-1C47-B69F-9108AA3DE7EE.root as _file0...
(TFile *) 0x5edce70
root [1] Events->Scan("Pileup_nTrueInt")
************************
*    Row   * Pileup_nT *
************************
*        0 *        21 *
*        1 *        15 *
*        2 *        38 *
*        3 *         8 *

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36850/28076

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @kirschen (Henning Kirschenmann) for master.

It involves the following packages:

• PhysicsTools/NanoAOD (xpog)

@cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @swertz this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mariadalfonso]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ddd366/22123/summary.html
COMMIT: 36199a4
CMSSW: CMSSW_12_3_X_2022-02-01-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36850/22123/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @mmusich move pixelTopology.h from Geometry/TrackerGeometryBuilder to Geometry/CommonTopologies #36773
• @guitargeek Clean unused dependencies from BuildFiles #36834

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ddd366/22123/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ddd366/22123/git-merge-result

Comparison Summary

The workflows 1001.0, 1000.0, 136.88811, 136.874, 136.8311, 136.793, 136.7611, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 43
• DQMHistoTests: Total histograms compared: 3449612
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3449584
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 42 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 181 log files, 42 edm output root files, 43 DQM output files
• TriggerResults: no differences found

[mariadalfonso]

@kirschen we can restrict the precision to two digits

https://github.com/cms-sw/cmssw/pull/36850/files#diff-1cdb6ca4228b4d9648f21393c825c9eee4b4a10681fa06021432dc607298bb8dR87-R90
The fourth argument of addColumnValue can be used to set the precision

[kirschen]

Hi @mariadalfonso ,
yes, happy to do that. However, just to double-check which value to put for the precision: In order to achieve two-digit precision for "Pileup_nTrueInt" in the usual range below 100 - would I put 4 or 2 as an argument for the precision in addColumnValue (or something else)?

[kirschen]

Tested several precision options for addColumnValue. "10" seems to give close to two-digit precision, see attached plots and scan with other options below (first few PU>50 values)

root [20] Events->Scan("Pileup_nTrueInt:P10.Pileup_nTrueInt:P8.Pileup_nTrueInt:P6.Pileup_nTrueInt","Pileup_nTrueInt>50")
************************************************************
*    Row   * Pileup_nT * P10.Pileu * P8.Pileup * P6.Pileup *
************************************************************
*       16 * 69.869911 *    69.875 *     69.75 *        70 *
*       20 * 52.111156 *    52.125 *    52.125 *        52 *
*       21 * 56.584854 *  56.59375 *    56.625 *      56.5 *
*       22 * 69.929237 *   69.9375 *        70 *        70 *
*       25 * 52.686782 *   52.6875 *    52.625 *      52.5 *
*       27 * 65.791412 *   65.8125 *     65.75 *        66 *
*       36 * 50.500423 *      50.5 *      50.5 *      50.5 *
*       44 * 66.613235 *    66.625 *      66.5 *        67 *
*       50 * 69.018005 *        69 *        69 *        69 *

Pileup_nTrueInt_Full_Minus_P10_PUGT50.pdf
Pileup_nTrueInt_Full_Minus_P10.pdf

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36850/28268

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #36850 was updated. @cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please check and sign again.

[mariadalfonso]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ddd366/22407/summary.html
COMMIT: 04c6ddd
CMSSW: CMSSW_12_3_X_2022-02-13-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36850/22407/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3764435
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3764405
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 45 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 193 log files, 42 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[mariadalfonso]

+xpog
minor changes in PileUp/nTrueInt as expected

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1