New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed unneeded #include
in ZVertexHeterogeneous.h
#36859
removed unneeded #include
in ZVertexHeterogeneous.h
#36859
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36859/28101
|
A new Pull Request was created by @missirol (Marino Missiroli) for master. It involves the following packages:
@civanch, @Dr15Jones, @makortel, @cvuosalo, @fwyzard, @ianna, @mdhildreth, @cmsbuild, @clacaputo, @slava77, @jpata can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e098f1/22142/summary.html Comparison SummarySummary:
|
Co-authored-by: Matti Kortelainen <matti.kortelainen@cern.ch>
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36859/28115
|
Pull request #36859 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @fwyzard, @ianna, @mdhildreth, @cmsbuild, @clacaputo, @slava77, @jpata can you please check and sign again. |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e098f1/22161/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+heterogeneous |
+reconstruction
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
While trying to understand a failure in the testing of an unrelated PR (see cms-data/RecoBTag-Combined#46 (comment)), I noticed that one
#include
statement inZVertexHeterogeneous.h
could be removed (the included header file is fromCUDADataFormats/Track
, and the latter package is not called inCUDADataFormats/Vertex/BuildFile.xml
). This would require a related update inRecoPixelVertexing/PixelVertexFinding
.While doing this, I also encountered a missing dependency in the
test/BuildFile.xml
of one Geometry package.PR validation:
scram
builds.If this PR is a backport, please specify the original PR and why you need to backport that PR:
N/A