Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed unneeded #include in ZVertexHeterogeneous.h #36859

Merged

Conversation

missirol
Copy link
Contributor

@missirol missirol commented Feb 2, 2022

PR description:

While trying to understand a failure in the testing of an unrelated PR (see cms-data/RecoBTag-Combined#46 (comment)), I noticed that one #include statement in ZVertexHeterogeneous.h could be removed (the included header file is from CUDADataFormats/Track, and the latter package is not called in CUDADataFormats/Vertex/BuildFile.xml). This would require a related update in RecoPixelVertexing/PixelVertexFinding.

While doing this, I also encountered a missing dependency in the test/BuildFile.xml of one Geometry package.

PR validation:

scram builds.

If this PR is a backport, please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36859/28101

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2022

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • CUDADataFormats/Vertex (heterogeneous, reconstruction)
  • Geometry/TrackerGeometryBuilder (geometry)
  • RecoPixelVertexing/PixelVertexFinding (reconstruction)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @fwyzard, @ianna, @mdhildreth, @cmsbuild, @clacaputo, @slava77, @jpata can you please review it and eventually sign? Thanks.
@fabiocos, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @bsunanda, @mmusich, @mtosi, @dgulhan, @venturia this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor

fwyzard commented Feb 2, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e098f1/22142/summary.html
COMMIT: 50b22a6
CMSSW: CMSSW_12_3_X_2022-02-01-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36859/22142/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 43
  • DQMHistoTests: Total histograms compared: 3449612
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3449578
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 42 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 181 log files, 42 edm output root files, 43 DQM output files
  • TriggerResults: no differences found

Co-authored-by: Matti Kortelainen <matti.kortelainen@cern.ch>
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36859/28115

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2022

Pull request #36859 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @fwyzard, @ianna, @mdhildreth, @cmsbuild, @clacaputo, @slava77, @jpata can you please check and sign again.

@makortel
Copy link
Contributor

makortel commented Feb 2, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e098f1/22161/summary.html
COMMIT: 9f39af0
CMSSW: CMSSW_12_3_X_2022-02-02-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36859/22161/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-e098f1/39434.0_TTbar_14TeV+2026D88+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-e098f1/39496.0_CloseByPGun_CE_E_Front_120um+2026D88+CE_E_Front_120um_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-e098f1/39500.0_CloseByPGun_CE_H_Coarse_Scint+2026D88+CE_H_Coarse_Scint_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3765022
  • DQMHistoTests: Total failures: 20
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3764980
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 193 log files, 42 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@fwyzard
Copy link
Contributor

fwyzard commented Feb 2, 2022

+heterogeneous

@jpata
Copy link
Contributor

jpata commented Feb 3, 2022

+reconstruction

  • technical

@civanch
Copy link
Contributor

civanch commented Feb 3, 2022

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Feb 3, 2022

+1

@cmsbuild cmsbuild merged commit 8f17ef6 into cms-sw:master Feb 3, 2022
@missirol missirol deleted the devel_includeOfZVertexHeterogeneous1 branch March 27, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants