Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-TB66 Add selection of SD's for HGCal TB application #36888

Merged
merged 1 commit into from Feb 14, 2022

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Feb 4, 2022

PR description:

Add selection of SD's for HGCal TB application. Selection of SD's to be checked depend on application. For test beam applications, many of the standard SD's need not be initialized. This PR takes care of that for TBH2 and TBHGCal applications

PR validation:

Use test workflows in SimG4CMS/HGCalTestBeam/test

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36888/28159

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2022

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • Configuration/Eras (operations)
  • Geometry/HGCalCommonData (geometry, upgrade)
  • SimG4CMS/HGCalTestBeam (upgrade, simulation)
  • SimG4Core/Application (simulation)

@perrotta, @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @cvuosalo, @rovere, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

bsunanda commented Feb 4, 2022

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4c7be3/22231/summary.html
COMMIT: 4e5b23b
CMSSW: CMSSW_12_3_X_2022-02-04-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36888/22231/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3766018
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3765988
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 193 log files, 42 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Feb 5, 2022

+1

@cvuosalo
Copy link
Contributor

cvuosalo commented Feb 7, 2022

+1

@srimanob
Copy link
Contributor

+Upgrade

No change is expected with this PR. It should be better to clarify the purpose of this PR to the PR description, e.g. to be used for future, to test. @bsunanda

@perrotta
Copy link
Contributor

+operations

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@srimanob
Copy link
Contributor

@perrotta @bsunanda
If this PR is for test-beam only, then everything is clear to me. Thanks.

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e248138 into cms-sw:master Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants