Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of a dynamic inefficiency module scalefactor in pixel digitizer #3689

Merged
merged 1 commit into from May 7, 2014

Conversation

ahazi137
Copy link
Contributor

@ahazi137 ahazi137 commented May 6, 2014

Second iteration of module scalefactor for dynamic inefficiency simulation in pixel digitizer.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2014

A new Pull Request was created by @ahazi137 for CMSSW_7_1_X.

Update of a dynamic inefficiency module scalefactor in pixel digitizer

It involves the following packages:

SimGeneral/MixingModule

@cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@civanch
Copy link
Contributor

civanch commented May 6, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request May 7, 2014
Sim -- Update of a dynamic inefficiency module scalefactor in pixel digitizer
@ktf ktf merged commit 7677ace into cms-sw:CMSSW_7_1_X May 7, 2014
@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants